Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp741976rda; Sun, 22 Oct 2023 07:56:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPLMi+jGpqiTAF7OBZP5QhSZhg9AWDarqKltr1W2qVS4xaj9LKbElZ+KxfyfzxMgC0Qqfi X-Received: by 2002:a05:6a21:4983:b0:172:83b8:67f7 with SMTP id ax3-20020a056a21498300b0017283b867f7mr4585067pzc.44.1697986611603; Sun, 22 Oct 2023 07:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697986611; cv=none; d=google.com; s=arc-20160816; b=B4T6BtQsgHI9qXJq4DJiTaLpaSTNZnRsFF/y+/vSR2PTI2pmy4MkGUBccCJ2MZHoPm ZzutmRCpPp5gbaB2QseobCSqFmuqnirzy5lst2GUOe47dp/zE9OWCQUgyNyT64H9a6y0 mBk3S8/nejoXFA2ZapytdLeRvQDjlSMq3LKLPEZzt2n2qUz1gsx36osWgMLbCmqCaTKV 7N5dMIT1iHKFOLGXKCYnWl5fM8mtx+0P7wodyQe55YyLunaAt+AYwquUpLJZdhfwYqQ1 WqUmcXve4C7LQzPndgu9mkiN4xNisPxg6+LfyPMJir16ru4m6dgISCtJutHHXbyAIkkL Oc9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NEHDKrDMa+I1xpNJGVIEipS66KDJtx+HuwbHhP75gEw=; fh=Y2IfAqdjkYQAx7XZcGq/8JceY1atOOwfX771vvMvH7o=; b=LN9TLFCPzvDdBoVN9zI6jfQ9v2DxT96KV4d/sme265BKVLuzWlabwmfkuQLsmifcvD bbQ2OZOqbZoNczUKzW1eRYCQOQMRyHW9IfpL4mh7ktQqLCBGGEmEpd7FcuWWCwu8ZMNY KsU4Yak1gnKlNnU6SpLui/6yjmu76EbZfCGwnY4NPcdJSZjV/BciFqnaVXqwl41reVr0 dljSGBHyqQWRVdgg0KAMxL9Mo0hGkohC9FqO7YWLGhNPi4QjnRVnfjKG77ibgJhqgurV /XPa0g0TXvL+Q8to2bz0e4meWFA/ZdkPZ2Rt/NLm3s8g3YcL/gEriB11eIQA+3citm7C GLTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jACice5j; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id ij6-20020a170902ab4600b001c9e765e151si4903591plb.116.2023.10.22.07.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 07:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jACice5j; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 269488057D8E; Sun, 22 Oct 2023 07:56:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbjJVO4c (ORCPT + 52 others); Sun, 22 Oct 2023 10:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232397AbjJVO4a (ORCPT ); Sun, 22 Oct 2023 10:56:30 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C64CA4 for ; Sun, 22 Oct 2023 07:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697986587; x=1729522587; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8IYcx04IqjuWbiFS4dpdSngvYA4jVhEnwwR1sjy/Ykc=; b=jACice5jayuMq0PQvQ2hlSquVMitS8R817z/+1SkRtqh4fNpHsipwlM3 1fTAgPDntYmsI2cwC/dUfawpfRleylMchiZ9RBT/F7oWs30WIgiGdUWtA Sp/eLPAg8hH2hvUKqJFWz/XrTzTwRXRtPt0iEHS/lZv5qLgE18Gvp74q2 qOM3Bdgy2l707ErT9pBGOWmCiDmjsVRahtDLkYPxiHvyRAJo4rGsPci8r IM+WwpQnS4AUmpRde6xriTBN2UFyDwOAenw5GFdK3kVxXUVwsrC6oKeyY g35x1IMRypcKX9MNH6A6NmBAK7lg2OGnaQ5t7qVH4irvAaJcCniawtNx/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10870"; a="472925862" X-IronPort-AV: E=Sophos;i="6.03,242,1694761200"; d="scan'208";a="472925862" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2023 07:56:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,242,1694761200"; d="scan'208";a="5556216" Received: from umark-mobl.ger.corp.intel.com (HELO ggreenma-mobl2.intel.com) ([10.214.231.87]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2023 07:55:10 -0700 From: gregory.greenman@intel.com To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Johannes Berg , Gregory Greenman Subject: [PATCH 08/10] wifi: iwlwifi: mvm: show dump even for pldr_sync Date: Sun, 22 Oct 2023 17:55:54 +0300 Message-Id: <20231022173519.30e614ecd540.I47324f555ebcf22d0dd0afa94e7ca0af53a9fdba@changeid> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20231022145556.244202-1-gregory.greenman@intel.com> References: <20231022145556.244202-1-gregory.greenman@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 22 Oct 2023 07:56:49 -0700 (PDT) From: Johannes Berg Worst case it's extra (garbage) data, best case we see why things failed ... Seems the trade-off is better if we print it. Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 8bba59d83b30..fef86a8b4163 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -1979,9 +1979,6 @@ static void iwl_mvm_nic_error(struct iwl_op_mode *op_mode, bool sync) { struct iwl_mvm *mvm = IWL_OP_MODE_GET_MVM(op_mode); - if (mvm->pldr_sync) - return; - if (!test_bit(STATUS_TRANS_DEAD, &mvm->trans->status) && !test_and_clear_bit(IWL_MVM_STATUS_SUPPRESS_ERROR_LOG_ONCE, &mvm->status)) -- 2.38.1