Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp970152rda; Sun, 22 Oct 2023 19:36:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9ZP6NYAvzZSvKCvg27TfyOIzepCEemhBl2ebkkt1QJuPjAXzSdzGmaZPeApS7iaISMhQW X-Received: by 2002:a05:6871:522b:b0:1ea:7bd1:c495 with SMTP id ht43-20020a056871522b00b001ea7bd1c495mr10384796oac.27.1698028562072; Sun, 22 Oct 2023 19:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698028562; cv=none; d=google.com; s=arc-20160816; b=Mo+DsO8QsP6F++8KmmGIj20h+pmk4HWF0iwq2ThZ3jx3aDCUj5XJmHARBrsL43FDtt JVMuvOHFHHnh4XuJt2ejxxfX5zeSpEfcA14oo0ssmaQDsq695WucfZMjypJ9QFRzhpVo 80VlYpQ/zr60dymIAjAmd29aT6tql7T9tynXXPug6SDHUspRHp8phmH8AS2T3HJnFqT+ OnBhwSksP9DFC7s+W4EFbQjc8GtNDRuGig/FZQ74IA+EcA1PXK+pt5gVZBgCEIZjLmlh CrJAQFbEUeEeMGjtaJdssP4GDxP2Fc4F3YPzJdEH3VrvbOtJBw58rA1WiUOPBS+QC2Y/ SwLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=+/qTUPzaYYm3rGSSD1M3bVOXnD5Iz9DsOKvdDdP2ef4=; fh=pZpLv3JBu7ewThcXtBU3x3uGUeTqUHmHtpmV6AvLzGM=; b=ef248SxA+FFT1GucqE09qclwdLYUwcLoH0mOmCC7dgFBvnWsRtN79yjNysPH4Z7K4K atMYDceX/Ro2lUbWIsA8TnV2PQX9AyZ3+YGUPY2ADMraz/U332I4LAQYqexamF4HpHkX XDBymMky9WmlqTQL2GF8HOjgkA4cwlelwZ4pXlvp0YYr5CLJifdurbnhC0pU538hnxG5 lbzUmRuPub+uOTC4R9bPYYOy5nfXgSReWfe9nMLI+qYmxwoU82m/vDlOhLOf003CkDi+ NUr50+618Tzpvpe9H+hn4JcLZQrt7bvxyANaI3niuCGaNKRhJh7IJAgsf03B5J9QHuO3 LhUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id d63-20020a633642000000b005ac13270364si5687107pga.732.2023.10.22.19.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 19:36:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6586F8080E21; Sun, 22 Oct 2023 19:35:47 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233174AbjJWCfq convert rfc822-to-8bit (ORCPT + 52 others); Sun, 22 Oct 2023 22:35:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233161AbjJWCfp (ORCPT ); Sun, 22 Oct 2023 22:35:45 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC74513E for ; Sun, 22 Oct 2023 19:35:43 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 39N2ZX6U02657782, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.93/5.92) with ESMTPS id 39N2ZX6U02657782 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Oct 2023 10:35:34 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Mon, 23 Oct 2023 10:35:34 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 23 Oct 2023 10:35:33 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Mon, 23 Oct 2023 10:35:33 +0800 From: Ping-Ke Shih To: Dmitry Antipov CC: Kalle Valo , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal Thread-Topic: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal Thread-Index: AQHaBQYdHgwLYR6VPUScH2u7+eRFNbBWqH1g Date: Mon, 23 Oct 2023 02:35:33 +0000 Message-ID: <5b9ea29daaaa4ebb8bc75cd384aaee80@realtek.com> References: <20231022163628.111991-1-dmantipov@yandex.ru> In-Reply-To: <20231022163628.111991-1-dmantipov@yandex.ru> Accept-Language: en-US, zh-TW Content-Language: zh-TW x-originating-ip: [172.21.71.113] x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 22 Oct 2023 19:35:47 -0700 (PDT) > -----Original Message----- > From: Dmitry Antipov > Sent: Monday, October 23, 2023 12:36 AM > To: Ping-Ke Shih > Cc: Kalle Valo ; linux-wireless@vger.kernel.org; Dmitry Antipov > Subject: [PATCH] wifi: rtlwifi: cleanup struct rtl_hal > > Remove unused and set but otherwise unused 'bbrf_ready', 'external_pa', > 'pa_mode', 'rx_tag', 'rts_en', 'wow_enable', 'wow_enabled' and > 'hw_rof_enable' (which seems to be an erroneous duplication of the same > one of 'struct rtl_phy') fields of 'struct rtl_hal', adjust related > code. Why not removing 'hw_rof_enable' from 'struct rtl_phy'? Then, this patch can be _purely_ cleanup unused code. Ping-Ke