Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1092836rda; Mon, 23 Oct 2023 02:09:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEH6lfjMUeGjDDBp6ULRSZfidQluk5U5M9MPl7OVgGZD4mabp1uiidBvOlVwivhe5NSPCEA X-Received: by 2002:a05:6a20:4ca2:b0:179:fbf5:4fda with SMTP id fq34-20020a056a204ca200b00179fbf54fdamr6150351pzb.57.1698052145322; Mon, 23 Oct 2023 02:09:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698052145; cv=none; d=google.com; s=arc-20160816; b=MvL1cCLFM0K5mauSHWqWLtG3RXf77PXf7tbWHc9uljLLxHFTR9UMR0GUzYyWzpaj6E 4Mh31aWcvyYzfDsGOAABdEeaVWizN5HTvNuLpAGo6tc+bY2AZyHae0hFIl2W2DPLkyUE clJ6r8a57KKT0wwdogpkR5UGoC/DeXf7xPwkcYW+qaQHoGGO4rN8x0/Pd9Wn71MDtjjV 4Dzv12b5krfn5EoOCVmxAC4zuiEht4wXcBcFetlfyGG3HMKjv1drl619Ppf5GMP4+fNc kYhGyp3RsTmrbLGKMh9AvYhazGK/KKlpPb+hSShH49/sWXp5j5xPxSwq/zKrjIWRhDaK xF0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=paxb9wqK/L3UIoPysc7MDYsJSwKL6BJLqhvL5Snh4SE=; fh=D/28rz/pcw7xB/gpiKQ80xCwUlYovD8iDM2p9Kg5zWY=; b=XElZC0iL4zOC68LvKY/TXfLsSVMPoLqp8wF0c2BDm2ZxHiQx9m7zpSVY2CF6watPtO PjXoaPlzOoaP2CcwbjOtDu1JThtkGlHQjIxXWIXl5Xv/OI7RES8vfVA1Klo1m5gTlZQg pD9dfFZ5qxgY1dpmQ+D1RjoJjEK03E2etRZVyNfaSLOiO/7Cvr4hFuICbQzHktar7R+F Pd1waaBfML/IiEak+wF5MUvkxYGpwhIA00WHemGy7Alh/3F9/yXIp2DW2zNZnbKy8Nxv XqYRX849BcWsW58qLUXlpJETDqvAVtNG029Rz4sOoyQJq3SvR4YSYpMki919HmExg8iP x+2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fYhWq3tM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z1-20020a17090ab10100b0027ce6cd3144si8605114pjq.126.2023.10.23.02.09.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 02:09:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fYhWq3tM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 2EFFB8043AF3; Mon, 23 Oct 2023 02:09:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjJWJJA (ORCPT + 52 others); Mon, 23 Oct 2023 05:09:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjJWJIy (ORCPT ); Mon, 23 Oct 2023 05:08:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D6298; Mon, 23 Oct 2023 02:08:51 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24111C433C8; Mon, 23 Oct 2023 09:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698052131; bh=jwRsyL0IKugyJxiMd8kLsgpJe00BKc6ZBp9nnsSKdh8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fYhWq3tMJe5ZmbkFSfJ7QJdxNCXC3N996oh0H9CZpO/zYTlGkS9yuOamWKbktfKoG ObjHvauvkniDP+f/fk7s47NMI7wwQOQGVFQWv2/JfWAyEH6mGFARenFYfm+QMfZ36M 20DZ4zdLoadEbR373pJFoYwBzFIVTlrKwV4CmSk4aggq+KSYJ5/idMRTKCT5oZmnvl Dm90Jz3OcYwpFPHOwtzZAqUV66OwRzYe7fvGm6bn0kaoR0BtKDOTOtT0CD4G7cnKQn VyhHT5ZGOafX0kngTAPkYN6kJTeUc+CZgKB+rK7xxXHGeuvNVkfwSPRvFu3d13dAye Wpu3S9cuZnBoA== From: Kalle Valo To: Chen Ni Cc: gregory.greenman@intel.com, johannes.berg@intel.com, mukesh.sisodiya@intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: iwlwifi: Add check for kmemdup References: <20231023064501.274599-1-nichen@iscas.ac.cn> Date: Mon, 23 Oct 2023 12:08:48 +0300 In-Reply-To: <20231023064501.274599-1-nichen@iscas.ac.cn> (Chen Ni's message of "Mon, 23 Oct 2023 06:45:01 +0000") Message-ID: <87zg09zowv.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 02:09:01 -0700 (PDT) Chen Ni writes: > Since the kmemdup may return NULL pointer, > it should be better to add check for the return value > in order to avoid NULL pointer dereference. > > Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once > fw dump occurred") The fixes tag should be in one line. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches