Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20231020094654.33258-1-dmantipov@yandex.ru>
In-Reply-To: <20231020094654.33258-1-dmantipov@yandex.ru>
From:   Brian Norris <briannorris@chromium.org>
Date:   Mon, 23 Oct 2023 09:37:35 -0700
Message-ID: <CA+ASDXPwwSvHFcTrV+PmpXMFxWaY+VyUS9qNFzHnMKxMXNnT1Q@mail.gmail.com>
Subject: Re: [PATCH 1/2] wifi: mwifiex: fix SDIO firmware read timeout handling
To:     Dmitry Antipov <dmantipov@yandex.ru>
Cc:     Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 20, 2023 at 2:47=E2=80=AFAM Dmitry Antipov <dmantipov@yandex.ru=
> wrote:
>
> In 'mwifiex_sdio_generic_fw_dump()', move the check whether
> 'sdio_readb()' has failed for MAX_POLL_TRIES times out of
> the reading loop. Compile tested only.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  drivers/net/wireless/marvell/mwifiex/sdio.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

We've already discussed and rejected this patch, if you aren't
planning on doing any real testing with it.

Subject: Re: [PATCH] wifi: mwifiex: fix SDIO firmware dump wait
https://lore.kernel.org/all/CA+ASDXNu-CWa9V5Oc-01pLp72iMVRw7m46+bDdNUxVmfrR=
9PSQ@mail.gmail.com/

It's *probably* correct, but it's risky without any cursory testing.