Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1345573rda; Mon, 23 Oct 2023 09:41:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYWh3n5G+MWqtemtudJPOTek+3Z9KHAtF6Wo29QQph3EjkGfYsmT+vSKbVdbM1XmPt1UpB X-Received: by 2002:a05:6359:5c20:b0:168:e177:b2bf with SMTP id pu32-20020a0563595c2000b00168e177b2bfmr2781874rwb.5.1698079293788; Mon, 23 Oct 2023 09:41:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698079293; cv=none; d=google.com; s=arc-20160816; b=pTrTZ6fhqqBnKX1LpBxT4ooGDTe/f4pUyucz8Z/OHORZgOhDpmvAC2WDbxjY1iOyYp pBaimZwmjuscZmU8LOYUkR/tZ5k9lzdDncz/sFht7eVfQRL0bnQIyoeY4LyzVNGti84J SJMr23imQ8DlkebrzqmqsNCRt2Snx/lJDDrKx4K7fKS38nCEN0WlGfxqMfQCskA6KNg7 AmFgkkJuLTRvo6Kgm6V1m3l5qBdv+Fvwkw4jS/hSEQQB33t9YLGBlVPloeMNVT7B7Bp3 5hV3dcMKrPNqY1MIs/L5tpP41wEaLRDp1YDzqNXyNv3o2PjdbA/pN7heLjhMfKZMmUiY PhEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zJ1LnQk5hE9Rm4j4maun3Cp3VuWdPviOHZQpOK7/ggU=; fh=hQUEiiksHvYN/EFmEKRXMJqwCC0zT2cV3viCNHAv7Ok=; b=T4ZJP456pjJI/1FahkMeKuzZMlDF6Q1i+dfoeW144jX74nKgcnud1tjUh6+bqfzr9T tNCJsfsZTOVdemtRZX3/CCJR2xsmd3JINXK6yHbC28/dPiqbVj+Z7uElsbkpAT1nEnHF 4kWaMOwXWOHwfDtnt+zQeNz2BzIG/N9gfKq7XGY+EaNqH2g7DGkRt3N9jtHsHfbNohhJ 5I5QWJbbxH/v+kd6aeRKYHDK12G3XShzMK6IJu9mEHxb3Wi33Dl2wjbs6dYqzMzK3Rn/ HzQzhNKEZmtKs3Cnlwz28vOd3CYPuTc/gwC26cclaRxms023dQc1HrCnEzFukEkRsVSq i43A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNrVnAGg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id a21-20020a63e855000000b005b881b8aecasi5487187pgk.440.2023.10.23.09.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 09:41:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNrVnAGg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 74AB780613B7; Mon, 23 Oct 2023 09:41:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjJWQlZ (ORCPT + 52 others); Mon, 23 Oct 2023 12:41:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbjJWQlZ (ORCPT ); Mon, 23 Oct 2023 12:41:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 638098F for ; Mon, 23 Oct 2023 09:41:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76F4BC433C8; Mon, 23 Oct 2023 16:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698079283; bh=WAm74M7mbG38lwboqiQzFnKHRrC1aVyJgkBL0L2vwCk=; h=From:To:Cc:Subject:Date:From; b=fNrVnAGg0i2rOZZlBmfXG296ACi0jqjRnyBSyE6MKU7LpFq/0GDHqLDM4zwvdL4rE NDYhEp16ThDgBcnTa0XDOI6KXaGjVvn1uxHE0Pir5z7i1TXQBQ5lwceSm9i+BvXu3v 0wwDJNO0i5w36JEZkkL1k9PGE1/1HUEzat2vRIPsRzHje/IoF058gKyvbchM67/TOC 0+nUAOYPuS7tvo5RlVRxr/9NAMtARBpy/aq8KCyJTTDDlsB/KXEcBv+BoutdGIupPt loZeJWhykrGOAUUmitv681PfTt4LWJB78r+cieWE/rXQ7LR6VTitCFptSw+5IHUUHh ibHbgj8lF5DmA== From: Kalle Valo To: ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Subject: [PATCH] Revert "wifi: ath11k: call ath11k_mac_fils_discovery() without condition" Date: Mon, 23 Oct 2023 19:41:20 +0300 Message-Id: <20231023164120.651151-1-kvalo@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,TVD_SPACE_RATIO autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:41:26 -0700 (PDT) From: Kalle Valo This reverts commit e149353e6562f3e3246f75dfc4cca6a0cc5b4efc. The commit caused QCA6390 hw2.0 firmware WLAN.HST.1.0.1-05266-QCAHSTSWPLZ_V2_TO_X86-1 to crash during disconnect: [71990.787525] ath11k_pci 0000:72:00.0: firmware crashed: MHI_CB_EE_RDDM Closes: https://lore.kernel.org/all/87edhu3550.fsf@kernel.org/ Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath11k/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index ec46e2ee6ddf..7f7b39817773 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3732,7 +3732,9 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw, arvif->vdev_id, ret); } - ath11k_mac_fils_discovery(arvif, info); + if (changed & BSS_CHANGED_FILS_DISCOVERY || + changed & BSS_CHANGED_UNSOL_BCAST_PROBE_RESP) + ath11k_mac_fils_discovery(arvif, info); if (changed & BSS_CHANGED_ARP_FILTER) { ipv4_cnt = min(vif->cfg.arp_addr_cnt, ATH11K_IPV4_MAX_COUNT); base-commit: 5b6e11406d5c198c402e8b7f7085a8c229198ba4 -- 2.39.2