Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1371828rda; Mon, 23 Oct 2023 10:26:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBd3o9O55St0btfHE1nBpNMPRI4TXI3Yx8J9uOsQFncIjdGri611f+/zkF2SS+RwoUKtea X-Received: by 2002:a05:6a20:12c5:b0:159:e0b9:bd02 with SMTP id v5-20020a056a2012c500b00159e0b9bd02mr272444pzg.40.1698081976734; Mon, 23 Oct 2023 10:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698081976; cv=none; d=google.com; s=arc-20160816; b=hnoRvYK1jLtpA1iV8JNqWuVAArSSdCxo02iz9b7Qh+HRJrq4JgbaURIe9vAqPoebCn 2S58jGVQN1edxvjXV3alCL1nZ4rzC1eM4L9NJGr1qJBBQO4kmyDBLTzAIPw7CyJpJX9k KAsR7PhbqQfCbhUnY2O82shtvIInJthZ/TcB5b/iA5QObDWcvQXgyM9qR0tCbLJCQT5t 28cD9X8YsQPKbdKedGDhWLzTjAX8bNpoUiaHh9/EhhQV4IYfZzG12rsnhiwkQZmFN0n/ sZDSAISD5sSn+0ixyojLbzd560SjVRU9UqwDKS4FHgo3trZqsK5gViW7NHeBbsXXocrn xt1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=ADROjHXDSxJOcic8oBavFLfZUVrjUWBbGvbsddHyjZY=; fh=rMViRUXMcpwts00tnWIqSaDpfyZ7i6w6Qd30cdc6wgo=; b=SFmszBN8rbD1H1AYgUCNnIPkNYnI3j20751nsmHziQKJ2iPk/P+fuCeeYg60BYK2+X Db9s+/eYNtVLY1mM3JJpTP7b2kzbjYgfDOiilBu9Tvp6iyGZfF6qdAmnt5vcjN9N+Tmg DLAMDwhXbVGEa+urG+hl+iotKwjHuXCgwTkZUA3buE7TBRjk6iiPRV8N8d5NTbXtPRof IqEIiff8QQNTeRkoZqtwyROub9ZysekUOtbYfugLC6EWvHoYRglPLKUxLhGq42uvy6mm o/Nr9eYXg50p3oGgU1FkARBZ+BMCDBmgOrWatzo3ZGegqXvPBBLiGiOJZDYU3olfb4GA GWqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tCSY5hUJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id bx23-20020a056a02051700b005aba9cdf091si7368185pgb.579.2023.10.23.10.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 10:26:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tCSY5hUJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1C4A28035112; Mon, 23 Oct 2023 10:26:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231206AbjJWR0M (ORCPT + 52 others); Mon, 23 Oct 2023 13:26:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjJWR0L (ORCPT ); Mon, 23 Oct 2023 13:26:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC6B6D7D for ; Mon, 23 Oct 2023 10:26:07 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FEBCC433AD; Mon, 23 Oct 2023 17:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698081967; bh=pRYJeBP+BNiuIIA9Fk8JjeoseAZbCclgVy26xu6dGJU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=tCSY5hUJIW2zKpNnx/9yCNW7sMu70RKR0SrUP3g+HkhwKIeWDPbEjTv0yFQJ9duH+ F/RKAMLo0hzCL+Rgkj/PeOsmBVFylUJTXLWyyhEBkvl4AouB4aZIYsQGu/T+h+l2Uk d06tZX5864zTHSD5aBy2vJFNPTBiicd8clBeOTNRMWP5qyax9f4ylNo3WayrwQa7Cj /lm0frkFcIDZAJkB3MRjxq5FKmWgpxDw6DyhS4IibMQsWjXlNXo5TS1zQ5a3OX+e1l n0XjbTas1N6MBIzfbz3nAhnrEUGPmNn7J4ous745jMfi15N55SjAJ69gWdx8ZS+6I7 s6BUdlkc7Rgmw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rt2x00: fix rt2800 watchdog function From: Kalle Valo In-Reply-To: References: To: Shiji Yang Cc: linux-wireless@vger.kernel.org, Stanislaw Gruszka , Helmut Schaa , Shiji Yang User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169808196400.695306.3954169620503448158.kvalo@kernel.org> Date: Mon, 23 Oct 2023 17:26:05 +0000 (UTC) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 10:26:13 -0700 (PDT) Shiji Yang wrote: > The watchdog function is broken on rt2800 series SoCs. This patch > fixes the incorrect watchdog logic to make it work again. > > 1. Update current wdt queue index if it's not equal to the previous > index. Watchdog compares the current and previous queue index to > judge if the queue hung. > 2. Make sure hung_{rx,tx} 'true' status won't be override by the > normal queue. Any queue hangs should trigger a reset action. > 3. Clear the watchdog counter of all queues before resetting the > hardware. This change may help to avoid the reset loop. > 4. Change hang check function return type to bool as we only need > to return two status, yes or no. > > Signed-off-by: Shiji Yang > Acked-by: Stanislaw Gruszka Patch applied to wireless-next.git, thanks. 69708fbb2c69 wifi: rt2x00: fix rt2800 watchdog function -- https://patchwork.kernel.org/project/linux-wireless/patch/TYAP286MB0315BC1D83D31154924F0D39BCD1A@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches