Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1912869rda; Tue, 24 Oct 2023 07:08:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxRisMEifKDf4j/1RKK6/sBG6HADQNZFOrgBzidn7IqwcOeUoDrZYiZ2hpMVNymWuFCy9/ X-Received: by 2002:a05:6a00:2347:b0:6be:4909:d66a with SMTP id j7-20020a056a00234700b006be4909d66amr9813047pfj.17.1698156480296; Tue, 24 Oct 2023 07:08:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698156480; cv=none; d=google.com; s=arc-20160816; b=at2UW8x9nI4zrzHRP0ki+FwxERFiC752FWyy9XsT/A0ioCvsv5pmQFlBTv4HUizaW4 4w9pRGRVB9d1uqvTEsseGTvB0nBSy3mvr1apOF2WVAWheK2svgZK3wv5mDoZNr6p1PZ2 bShxyVwWi+KKcFkTgK/yuh3tSFjVoYcY26nUqw0J4zVk4QDU3yVilNSSkj+q1YBMGyMs 3wjZlIIxMMVkYhSvIRDPyZfFhcCPRyErutIt4JqXJqr/yuNMihTrBVBYm419NO0gPTya P4i8zv/wexm1V04z/fovsBt8yfY3CNK1UdY/+PYWAEk0rpMskP7rKLL36U+ttPwfgFtG Wh6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=SBC5NnKGCfkSHwBg8edLy6hb5d1wIwdbvAu+hGoZRhw=; fh=ZbuQJxpG4sNDMy/Ay9Jlt6FZ8b0H3FKyV275Wkpmla8=; b=FUswztxggx22u3NxvxPNL32xNpPHhmxyJTdOMUymX0SmiiB76hDxoOgjw9ql+FpuLd 3KVeTQsLYvA8VMIx+NFwxYwlyjjugcMur/jwHlGN5Zh3Emko6Oh60EV1ifYlci5k4x2p FutCz3Ddk5xunDMvglO+YV6vgjZS4xTyGsvJ11VWFIMXtObcndhOMPyDxudKLXPV711G 5nO3jwyqhTImzfxZpvSV3R+hHymhTpPv8aWPY54OceOf2euk1qAHixY+R5vINRP+mrka 6PZEdh9gDihe02CUhjUd9/uvWwrWuWD/YHxRk1+iDgd3B0FHHSBdZxneYCrX50coMjEx /YRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gXC+envN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id i70-20020a638749000000b005b33c54df10si8162115pge.482.2023.10.24.07.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 07:08:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gXC+envN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id A31CE8076CA0; Tue, 24 Oct 2023 07:07:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234664AbjJXOHp (ORCPT + 52 others); Tue, 24 Oct 2023 10:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234210AbjJXOHo (ORCPT ); Tue, 24 Oct 2023 10:07:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A259DA3; Tue, 24 Oct 2023 07:07:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10A78C433C8; Tue, 24 Oct 2023 14:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698156462; bh=9jC8oNZgHX1Zi6aWIvKR5WIBscBYWtT/XNF7Ji+UiB8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gXC+envN88pZ16F8KzAjczjiWBqEKfHwpJD0p7P+wmzdB+o7NwKEiLXAFTNwGw/1g dieOYHrquj917Fj/nh2ar4Oc8Wj2kFU+RX8UHAM2mzCoTWHtvOteXl2tsuuLYEvOpV vhzNHq5eF96otmpUqWODLhOHYs0IfVbpKVmsjrwylxLKKgTAk8QVJUarSBxggH+LZv 9i00MapnXdOhEsMDCibsxQUOp13U/KyXxxJWIPHsUoJ3lwq3tzXcjuLzexDz/vbXRK Si+n9xhtkO/wslDcK+pBQlm2SmySgNzvQuF0myT1gavca1fWMSqLJOW2UX0A4RLgpj fctl56uXy/gww== From: Kalle Valo To: Johan Hovold Cc: Jeff Johnson , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] wifi: ath11k: fix event locking References: <20231019153115.26401-1-johan+linaro@kernel.org> Date: Tue, 24 Oct 2023 17:07:38 +0300 In-Reply-To: <20231019153115.26401-1-johan+linaro@kernel.org> (Johan Hovold's message of "Thu, 19 Oct 2023 17:31:13 +0200") Message-ID: <87o7goxget.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 24 Oct 2023 07:07:45 -0700 (PDT) Johan Hovold writes: > RCU lockdep reported suspicious RCU usage when accessing the temperature > sensor. Inspection revealed that the DFS radar event code was also > missing the required RCU read-side critical section marking. > > Johan > > > Changes in v2 > - add the missing rcu_read_unlock() to an > ath11k_wmi_pdev_temperature_event() error path as noticed by Jeff > > > Johan Hovold (2): > wifi: ath11k: fix temperature event locking > wifi: ath11k: fix dfs radar event locking Thanks for the fixes. I really like using lockdep_assert_held() to document if a function requires some lock held, is there anything similar for RCU? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches