Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <3a40a14e-c597-e38d-f66e-b56a6f19ba87@candelatech.com>
Date:   Tue, 24 Oct 2023 11:31:42 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2] wifi: mac80211: ethtool: use best available link for
 default stats.
Content-Language: en-US
To:     linux-wireless <linux-wireless@vger.kernel.org>
References: <20231020152353.3705759-1-greearb@candelatech.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
In-Reply-To: <20231020152353.3705759-1-greearb@candelatech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/20/23 08:23, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> Best link is the link with the highest state (ie, associated)
> and if multiple links have same state, the highest
> frequency wins.
> 
> This makes current ethtool stats more useful.  Per-link
> ethtool stats can be added later.

The kernel robot is correct, this patch is buggy and would crash with a 2+ link
situation.  I'll send v3, though I don't have an AP that actually advertises > 1 link
so difficult to test well...

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com