Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2440102rda; Wed, 25 Oct 2023 02:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnILOGVSdYmFLj2DqYYyVvZTn7svWGet2pxZhi3IzlJfgEpVJ/Z2BYD5gGW/lnJ0DPDVMz X-Received: by 2002:a0d:cbc6:0:b0:5a8:6397:5bdb with SMTP id n189-20020a0dcbc6000000b005a863975bdbmr15420157ywd.3.1698227486469; Wed, 25 Oct 2023 02:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698227486; cv=none; d=google.com; s=arc-20160816; b=HW+4/sgc9ySFSsmCGpegvLC5Gyczt/oF5utyHcPbS8dTuyDPWunavYMXtMrqAkIONG xI3WXjQ7ncZUjaOC+QeyDTfSb50dEtZb+Dy0J0uVxqEeO62fGI9jTJKXZAesfbNGOKqX PmryepOWWnr/TOoc8CEd2uHayPu5jToLbA/YNmTxuCR/L7uFRiSDdj7khkztINWjCnF5 yjJCkVvDlnXDV43Wb9i6xmYn4iO50HVoBBbupLNftLnDyC2y1zDemDSWRQ/zjmYKwRZz vE7i2tBbUruagXjPiWJMeS0UWZ3AhLu4ZyuWM1y2fON9O8KDvU4PJ+fAksxesncCNuqV umXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=V3gzZNikqoNe6dZ/HQEoYFUPCdp3dyOFjTiEx30G6q0=; fh=S4it7r1EoT94yA40CGFud+UB0PPOPVgxMHurDclTTCQ=; b=nWXnx1oZXb9JMO+o+CjvRCD5mR4EN9h7lw98aBaHW7WESueamxnF2wVppwOKIJXQpL 1eT0nMgjOOhCaXr/R0hEGNG9K5lHqdsHdYWMKKqlvYMrjmsmv4EFo+d10oRVkTWXI0Gw 8zIUyc6lHo1A/AI9gSJU/QggGchoLiEqfDObvAqw7JkzbjhaWcymUnP/bbXRABidUE27 7F9SPUNwHtvCZxDHz/h4jjhM53htsP8mB0+PQQA6ychiDy8FWL3J2FB9oEES7orRzk8Z M0h/DyRmCIrqcQbbCExdcebF7Hh/1+Tligj/ve+LkE7OEx2uEWfHd2V80eG8oW5Ojn2t rxKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mk3aBPSY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u197-20020a8184ce000000b005a8aa020effsi10241788ywf.72.2023.10.25.02.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 02:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mk3aBPSY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D1F12802EE4B; Wed, 25 Oct 2023 02:51:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233973AbjJYJvR (ORCPT + 52 others); Wed, 25 Oct 2023 05:51:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbjJYJvQ (ORCPT ); Wed, 25 Oct 2023 05:51:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C70DD; Wed, 25 Oct 2023 02:51:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50ADBC433C7; Wed, 25 Oct 2023 09:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698227473; bh=+cg3kYM3oFry35hZbmbwSVjd6ek+Za/QIdrk5JlXVCU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Mk3aBPSYzxfaNtQwgFmWCAiO3PKRxQWVvwar4NEUMMiOvsIundUsqhpzRFFMObBCE QveXtgBd9HCA98TLqFTA7yovLjoI21iZM1b2zsZT+w7MRzWAckSLuIKE2YobbE61dQ sgLdpJ/XgcIOmVN79MziCxoVSJzNyhWmXslfB81mka1hPexK5GDEhlcoSjoBwK0fto bW9Wzd1ZHIMD7kMd60aPMQtGNiYylkYtgeclMtVyBvZnyl1bTaNtztUOlC3YFUNyfZ 2+dIJhrxa0fr8p8lwqkv2YcQ8y8axKaoishIr0bOR+6khcx8rQgNlfypsgPtQ8fVrF QAAdapnSoULUA== From: Kalle Valo To: Johan Hovold Cc: Johan Hovold , Jeff Johnson , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] wifi: ath11k: fix temperature event locking References: <20231019153115.26401-1-johan+linaro@kernel.org> <20231019153115.26401-2-johan+linaro@kernel.org> <87sf60xgs8.fsf@kernel.org> Date: Wed, 25 Oct 2023 12:51:10 +0300 In-Reply-To: (Johan Hovold's message of "Tue, 24 Oct 2023 16:29:07 +0200") Message-ID: <87bkcnxc6p.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:51:22 -0700 (PDT) Johan Hovold writes: > On Tue, Oct 24, 2023 at 04:59:35PM +0300, Kalle Valo wrote: >> Johan Hovold writes: >> >> > The ath11k active pdevs are protected by RCU but the temperature event >> > handling code calling ath11k_mac_get_ar_by_pdev_id() was not marked as a >> > read-side critical section as reported by RCU lockdep: > >> On what hardware and firmware version did you test this? As there's so >> many different combos we use Tested-on tag to provide that information >> in the commit message: >> >> https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag >> >> I can add that if you let me know what you used. > > I hit this on the Lenovo Thinkpad X13s and I guess the tag should be: > > Tested-on: QCNFA765 hw2.1 WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 From ath11k point of view QCNFA765 is WCN6855 so I used this one: Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.23 > Note that I've only been able to test the ath11k fixes (not the > corresponding ath12k) and I only tested this particular patch fully Thanks, I added Tested-on to this patch 1 and for the rest I added "compile tested only". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches