Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] wifi: ath12k: Introduce and use ath12k_sta_to_arsta()
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20231019-upstream-ath12k_sta_to_arsta-v1-1-06f06f693338@quicinc.com>
References: <20231019-upstream-ath12k_sta_to_arsta-v1-1-06f06f693338@quicinc.com>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Jeff Johnson <quic_jjohnson@quicinc.com>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2
Message-ID: <169823009956.891844.2307289880340272431.kvalo@kernel.org>
Date:   Wed, 25 Oct 2023 10:35:01 +0000 (UTC)
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> wrote:

> Currently, the logic to return an ath12k_sta pointer, given a
> ieee80211_sta pointer, uses typecasting throughout the driver. In
> general, conversion functions are preferable to typecasting since
> using a conversion function allows the compiler to validate the types
> of both the input and output parameters.
> 
> ath12k already defines a conversion function ath12k_vif_to_arvif() for
> a similar conversion. So introduce ath12k_sta_to_arsta() for this use
> case, and convert all of the existing typecasting to use this
> function.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

9ef118152ee0 wifi: ath12k: Introduce and use ath12k_sta_to_arsta()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20231019-upstream-ath12k_sta_to_arsta-v1-1-06f06f693338@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches