Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 26 Oct 2023 09:43:27 +0800
From:   Jiazi Li <jqqlijiazi@gmail.com>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     Johannes Berg <johannes@sipsolutions.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jiazi Li <jiazi.li@transsion.com>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wifi: cfg80211: fix bss rbn double erase issue
Message-ID: <20231026014327.GA24345@Jiazi.Li>
References: <20231025103304.22082-1-jiazi.li@transsion.com>
 <97bfc661-132c-48c1-a6c0-c662c1b37db1@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <97bfc661-132c-48c1-a6c0-c662c1b37db1@quicinc.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Oct 25, 2023 at 09:04:48AM -0700, Jeff Johnson wrote:
> On 10/25/2023 3:33 AM, Jiazi Li wrote:
> > If cfg80211_update_assoc_bss_entry call rb_insert_bss re-insert bss
> > failed because cmp_bss return 0, this bss->rbn will continue to hold
> > expired data, such as __rd_parent_color.
> > And this bss still in rdev->bss_list, maybe double erase in
> > __cfg80211_bss_expire later.
> > Double erase a rbtree node(with expired parent and color data) maybe
> > corrupt rbtree, so add a in_rbtree flag to fix this issue.
> > 
> > Signed-off-by: Jiazi Li <jiazi.li@transsion.com>
> 
> Note your Signed-off-by doesn't match your e-mail address in your e-mail
> header. From the actual e-mail source it seems Google is trashing your
> headers:
> From: Jiazi Li <jqqlijiazi@gmail.com>
> X-Google-Original-From: Jiazi Li <jiazi.li@transsion.com>
> 
> That needs to be resolved
Thanks for your reminder, I will use the same e-mail address in the
feature.
> 
>