Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>
To:     Dan Carpenter <dan.carpenter@linaro.org>,
        "Greenman, Gregory" <gregory.greenman@intel.com>
CC:     Kalle Valo <kvalo@kernel.org>,
        "Berg, Johannes" <johannes.berg@intel.com>,
        "Triebitz, Shaul" <shaul.triebitz@intel.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] wifi: iwlwifi: mvm: fix an error code in
 iwl_mvm_mld_add_sta()
Thread-Topic: [PATCH] wifi: iwlwifi: mvm: fix an error code in
 iwl_mvm_mld_add_sta()
Thread-Index: AQHZ8UAGpV4OYGX8XUOLDHDRXa2MybBcD5kAgAAAWBA=
Date:   Thu, 26 Oct 2023 10:44:16 +0000
Message-ID: <MW5PR11MB58102E1897D7437CD8E1DF27A3DDA@MW5PR11MB5810.namprd11.prod.outlook.com>
References: <75e4ea09-db58-462f-bd4e-5ad4e5e5dcb5@moroto.mountain>
 <79f70bb6-ca33-48fc-ab33-6a6cd8ba2e1d@kadam.mountain>
In-Reply-To: <79f70bb6-ca33-48fc-ab33-6a6cd8ba2e1d@kadam.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GrsxCxoWX+bbzlfwQA0ZRhaEpFTFSdjPGrUw3Xlt3F6eIQ4W1ZU77tHFSlz7?=
 =?us-ascii?Q?kBLoBmi60ehM4H6KChNaAvZThm9UmwHnKRg3mDtCh8yFb9WXyVfCcbChXAIs?=
 =?us-ascii?Q?AMdRgqu7Rkp0eHtWLuUxiW+Hip3e0UcS5Nx9FiwfFudSVzy5ryiNlcYvgXh+?=
 =?us-ascii?Q?RIcAR7hETjw4cXLSKRAmqbdw8W/lsmYkoRjZPp/GxXALf0PKgO+29uRBfuMQ?=
 =?us-ascii?Q?8FvA5xvIjtp6JKC4A48lojdrPOOrPNrMXV7MH0yZGEUzC40qmrpLYUKANkE3?=
 =?us-ascii?Q?T0WzHEmvXwlD/ZZXBOqQr8S73hZQ2XVUmjocpQU9nfE+3Tjj0QbiHkHXwLwZ?=
 =?us-ascii?Q?1VvjX4PDMY9H7KqE6/1B3LhvRiJgJHWdqY7gBHOiX2eQbCzC+Eq+RPRdGEGl?=
 =?us-ascii?Q?DHoiv+BR6a+kl+po6lfj5yiHjjx5IqHQVIX/IjVD+LN5txDs1q3pxnhgZgR5?=
 =?us-ascii?Q?uCq0UANO5a+7Tfowpxs6m4ZA9BiZqJnKh5l5oEJA4evUe9h7LebzuvOcH4L1?=
 =?us-ascii?Q?g/cQJF2xklLCBARzLvoaDtc35iAlUW656z6Ltrl3/DolMLKTQGRmZPiwPBEV?=
 =?us-ascii?Q?3oHs3Y1TVJGpfUZHYntudtMcHlIqZeNfmTOg6M8YxWKXb7+y1Voi6S2gsICK?=
 =?us-ascii?Q?txh9UrREJyBruiC3eBBv9JtD6YCEOcP4ZBCQl3hAnCgq76N3uKnFxbiXtSjs?=
 =?us-ascii?Q?xP/jLQlV2twW4i2/3SrYbMrVoZ4ONDkOMAZxRfFM18pAf7v+hLvE36XvvPXi?=
 =?us-ascii?Q?DoWtrXSCb6BaL2YxXKDTsIUzhqiqd2T1oafKpRyqoA8hnxDShRAu9gGXHd32?=
 =?us-ascii?Q?93ffdACTSVae04cYq348U5ycouqs+C8/mw0k1igVRNRGycl/B/T0j7pyzKUV?=
 =?us-ascii?Q?nDZo7QbEtbLHyCDBTmVFgFHdp7q+Ny2801Gr5OUqED3BNJtXcDLtY+EkNmK7?=
 =?us-ascii?Q?4xWm3gVlLPECFHONN7N1UtsSY8Yf6Qy2Kzb05PzuESeOARvQNdkd6nJxK1Yy?=
 =?us-ascii?Q?92VJKspEZ5O/WhRg0Q/DFJXDBQdAXZ6/k/4gvGZSmICyy4oLmS4yNgGi5myd?=
 =?us-ascii?Q?KzYmegpH679uwQDmpKUUYF5TgbufczBNLz/esT8ysrV448kVBDO9r11bCiGx?=
 =?us-ascii?Q?b+HYQAIhgYT9W3aspOY57ePNK3JDlv6yCf8oGK+U9gvs8Tzkf6X9+/83qlcH?=
 =?us-ascii?Q?LRBzaezp/HJmuZDggODHMKjir8o+VZCJoXWBYg/DdlI9S8hwWrjlpxe9VHps?=
 =?us-ascii?Q?+4VN08JISO1JYA8cGEd1NG/JCe/VpSfKH+PckiM5na+1+vCARe6IOW4fhB/d?=
 =?us-ascii?Q?fGJyyQSoZtftsQvB7YgnkMnGXyBtNAcW5rXwpNlsEXc9xEya914xNFmudoIE?=
 =?us-ascii?Q?rY+wWCbyD8lodtxQOl9c9pS1+IE5HGrExRtiK+r7J1LbyPKoozw91xR02kUv?=
 =?us-ascii?Q?mKBdsS0sSYbIxVJeYkJav7B8jbsqTjhVIcRaf4L1tMtLrXqLZ22Q0WgjWmEp?=
 =?us-ascii?Q?MtedXfoyA9GHsFB29Xdi2TZZ3vaZa7Es1TUHQAIJyoiwkTXwXg4T9xlI2zaP?=
 =?us-ascii?Q?cjQ5lW19uvFuRZ0+L+BmRSBI9McJMdEvVieI/6Y6eZBfEfo2uXHatMVh9w+U?=
 =?us-ascii?Q?iA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c7383fc-53fe-4a4f-e9b3-08dbd610807d
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 10:44:16.6234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NBWW8muyvcLZaXMFWsZkaa8ZheAUeamsCka9qMjuxSIBzAIp31pzT7l9NQZY4htJES2oLM6TAKFOKGPIE37MRfXSGjXwY1itf/lPTEmjxwYiho25ngon3xwUE0a1VqI9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8582
X-OriginatorOrg: intel.com
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 03:44:29 -0700 (PDT)

Hi

Sorry for the delay,
I am fixing it.

Thanks,
Miri

Miri Korenblit | CCG | WCS | WCD
Office: +972 2 589-7724 | Cell Phone: +972 54 846 3803

-----Original Message-----
From: Dan Carpenter <dan.carpenter@linaro.org> =

Sent: Thursday, October 26, 2023 13:42
To: Greenman, Gregory <gregory.greenman@intel.com>
Cc: Kalle Valo <kvalo@kernel.org>; Berg, Johannes <johannes.berg@intel.com>=
; Korenblit, Miriam Rachel <miriam.rachel.korenblit@intel.com>; Triebitz, S=
haul <shaul.triebitz@intel.com>; linux-wireless@vger.kernel.org; kernel-jan=
itors@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: mvm: fix an error code in iwl_mvm_mld_a=
dd_sta()

Ping?

regards,
dan carpenter

On Wed, Sep 27, 2023 at 03:40:41PM +0300, Dan Carpenter wrote:
> This error path should return -EINVAL instead of success.
> =

> Fixes: 57974a55d995 ("wifi: iwlwifi: mvm: refactor iwl_mvm_mac_sta_state_=
common()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> I copy and pasted this approach from similar code in the same patch.
> =

>  drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> =

> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/n=
et/wireless/intel/iwlwifi/mvm/mld-sta.c
> index 1464aad039e1..f2e952481ff8 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
> @@ -707,8 +707,10 @@ int iwl_mvm_mld_add_sta(struct iwl_mvm *mvm, struct =
ieee80211_vif *vif,
>  			rcu_dereference_protected(mvm_sta->link[link_id],
>  						  lockdep_is_held(&mvm->mutex));
>  =

> -		if (WARN_ON(!link_conf || !mvm_link_sta))
> +		if (WARN_ON(!link_conf || !mvm_link_sta)) {
> +			ret =3D -EINVAL;
>  			goto err;
> +		}
>  =

>  		ret =3D iwl_mvm_mld_cfg_sta(mvm, sta, vif, link_sta, link_conf,
>  					  mvm_link_sta);
> -- =

> 2.39.2
---------------------------------------------------------------------
A member of the Intel Corporation group of companies

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.