Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp998643rdh; Fri, 27 Oct 2023 01:29:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcG6TvtqGFbfFQ/YKTWjP1Fvs5mXlt/zAqqWcIiJkGhTw9GD2lzTGmclp3VjpPRE3O38QH X-Received: by 2002:a81:4315:0:b0:5a7:af7d:cee7 with SMTP id q21-20020a814315000000b005a7af7dcee7mr1982575ywa.6.1698395348166; Fri, 27 Oct 2023 01:29:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698395348; cv=none; d=google.com; s=arc-20160816; b=LsFHY4TpiJYaOYVhCuBe9mNYpQ0bVu+FlIISGPTIBurmYjt1wkMm2235MHcHlsoq/7 UP33/mjXyMArj8d1GlCW4DppSHLfULturw86lCItycHMH1hZZ66hg+Xx4jPMlRGe5hwq pPg/GCFqugio55PUtj0lMHImlhxJg46X5ANzqHCdHc3Jx9vZUFXUThNbAvDyyhJoUfw/ yZxO91W8za0WM56gZXb5Fqa7cZze/wtGudkXu2rixNCsEMKqJqysmRr6pcgNVfmmj7au 5VI+F/ffj9O8T7HUSPPhY7asGEVz17xjbagNNjSv/JAKvSyitQWMrw3H1ER2JGkX18oS K6hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=GPbkk3gkVplgaHqKTomai6xIgeShzlCIDS9WI6A0V/Y=; fh=6eVL3B0ZMY6DxGHOkgW0XHgVwCT4hBXOTfF13BDdipo=; b=oJQQKbUSf2/QKL25nei+qSh+dUM0YDBZmvCGBfnJMw0tDjMPYu5JZJZVxw5o4EsX4N du6t7bv953nV9ryMkQXiV13Sk6F1pAfJNFmL7qfUo2brOU8/X0Vwu4yiTlLx+D3xUB3M kYahwNJrtbqc9Gfg0tcmj73pKS/+1UpI3u/AGAhGR7WHCGOL9qjqXS7reK3U+0elXSHg xfjRCjGTqLYnSixHWcWZu6FbRo4ZfpAZnD/Y6SNjfzPpgpJN8LY0t/mktuk+g3ZYrqeo QsJqzqt4Ki7n3AfASYJ9N26/I+X3S9yqR9iP4x7u6XU7zZI9jXCBj4VphoK0nNOzBZ3X fYJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RbBNacKV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id k64-20020a816f43000000b0058dedc2af66si1640956ywc.521.2023.10.27.01.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 01:29:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RbBNacKV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9436C82CC45D; Fri, 27 Oct 2023 01:29:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345493AbjJ0I3E (ORCPT + 52 others); Fri, 27 Oct 2023 04:29:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345562AbjJ0I2x (ORCPT ); Fri, 27 Oct 2023 04:28:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91BFED42 for ; Fri, 27 Oct 2023 01:22:56 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D6B4C433C8; Fri, 27 Oct 2023 08:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698394975; bh=Nt7iWTc2zlF5adOjywSKI6AgxjT55FIpazXgJLLWuSY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=RbBNacKVnk01cggLRGk6iVxpvrTpY3LGYVf1kZRGZQq8cZ/XYEOU7qVfQNRWPCwTY pbT+XeUeV4fCNi7HhIMpOPVqw4LvZ0VvdYj3OJ9nbC93mmos4qc22YW9+7C9/PBdPY qac08mOV+MHV1RAbcxkv7Y238h+mG4lqyy+zZBOp5rzeBOWNui/kXGS322NOZjrlGm 7H9CK7hRHgDBHUN69mAhFlJU00OCadbZO3PYMhfBZpcqy4x/Zd8rOH9OcA+F/1gKrO 25Y2PVhALfuINhdlsRUp05prz0P5q0MmZ5KbCsTgGiP+ZJkdkBP3BRWPg3+p4T32w6 r7iEOfkG044tw== From: Kalle Valo To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: rtlwifi: fix USB device initialization sequence References: <20231027075920.116006-1-dmantipov@yandex.ru> Date: Fri, 27 Oct 2023 11:22:52 +0300 In-Reply-To: <20231027075920.116006-1-dmantipov@yandex.ru> (Dmitry Antipov's message of "Fri, 27 Oct 2023 10:59:17 +0300") Message-ID: <87pm10wk2r.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 01:29:04 -0700 (PDT) Dmitry Antipov writes: > Do not ignore possible errors in '_rtl_usb_init()' and tweak error > handling in 'rtl_usb_probe()' to ensure that 'rtl_usb_cleanup()' is > called when needed. Minor style adjustments, compile tested only. > > Signed-off-by: Dmitry Antipov Patches like this should be tested on a real device, compile testing is not enough. We don't know if there are hidden errors which this patch then exposes. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches