Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <323e1669-e145-21bc-a124-923303ad2138@gmail.com>
Date:   Fri, 27 Oct 2023 10:15:02 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH net-next 1/4] net: fill in MODULE_DESCRIPTION()s in
 kuba@'s modules
To:     Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc:     netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
        linux-wireless@vger.kernel.org
References: <20231026190101.1413939-1-kuba@kernel.org>
 <20231026190101.1413939-2-kuba@kernel.org>
Content-Language: en-US
From:   Jonathan Bither <jonbither@gmail.com>
In-Reply-To: <20231026190101.1413939-2-kuba@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/26/23 15:00, Jakub Kicinski wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Fill it in for the modules I maintain.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: linux-wireless@vger.kernel.org
> ---
>   drivers/net/netdevsim/netdev.c              | 1 +
>   drivers/net/wireless/mediatek/mt7601u/usb.c | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
> index 2eac92f49631..aecaf5f44374 100644
> --- a/drivers/net/netdevsim/netdev.c
> +++ b/drivers/net/netdevsim/netdev.c
> @@ -470,4 +470,5 @@ static void __exit nsim_module_exit(void)
>   module_init(nsim_module_init);
>   module_exit(nsim_module_exit);
>   MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Simulated networking device for testing");
>   MODULE_ALIAS_RTNL_LINK(DRV_NAME);
> diff --git a/drivers/net/wireless/mediatek/mt7601u/usb.c b/drivers/net/wireless/mediatek/mt7601u/usb.c
> index cc772045d526..d2ee6540ebb2 100644
> --- a/drivers/net/wireless/mediatek/mt7601u/usb.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/usb.c
> @@ -365,6 +365,7 @@ static int mt7601u_resume(struct usb_interface *usb_intf)
>   
>   MODULE_DEVICE_TABLE(usb, mt7601u_device_table);
>   MODULE_FIRMWARE(MT7601U_FIRMWARE);
> +MODULE_DESCRIPTION("MediaTek MT7601U USD Wireless LAN driver");
Did you mean USB?
>   MODULE_LICENSE("GPL");
>   
>   static struct usb_driver mt7601u_driver = {