Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2886792rdh; Mon, 30 Oct 2023 10:22:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiqnvg0ZEJgnYaivaG4lFtSkixQxr96/b3/At/OmvJY2d8F31YYftYFelg8v7BYy7hdKV7 X-Received: by 2002:a05:6a20:728f:b0:135:1af6:9a01 with SMTP id o15-20020a056a20728f00b001351af69a01mr9612441pzk.8.1698686569713; Mon, 30 Oct 2023 10:22:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698686569; cv=none; d=google.com; s=arc-20160816; b=zYw24c4rH01qu/3oIpWXwo5HqFp4KPERSLskXP5MMYyzaG36Slexm7lrUQZo4vYcjX cGDayK4E5lVdmCl908Hwq2z0UJXSbi0TgJDldJcoxB5BmwQAOhYXlilGWDGnq1Ojb4oj P6C4kOUXlMjP9zw/Ae9MBfuO6J+IQQowCYynEgYXzjM+TMR2l1dubcqEJRicZIeixOlf 0Ht+bsZj9q/Qt4wNk+ZbuTkLHkVH0QifY+uuQwKF8urdKvBKg1OKuECUZCkwM7j2hOgu dabV5OK57joZuRk9fxP0skZEMIbQNH8sJqpSp1Uo6v1nD20qwvPpetItWsIGzAfHbyt3 B77g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=pC0gsTUGTu/ZnWWQxrKY02U6HtoSopm+veRYu4ixhh4=; fh=W+d0VTlB06MRf7YcZ9fsTH6rmN1qgblnN3a4fITKvd0=; b=v1weu1z+qzU2JLtegfYiKO2YcnI3nnh405MHEp7xX/6VpV0uAfRu+89gpgFFfmHxAD 1n8kaF2RBGc23+DionQujvW5R9pdI/SC9SbMJMP+iUSYzh64mqFBUkrC+QFuZFgFUl3Y 8IS4qfaAQrtiwDzddD/yV1Aqvu6q5gHR39Fuolt2syHXxx4KeRGiqkTSTGiiSHmbqQB+ rg8qmeUh8EJyje55rYhnaFRLRO1Ttoh9eX98g8psgZZAVXwcBUwwK2gprPhDPPFFT5aW FF0pxAgpw/7MKmjlBnMwuPKBjNeQh7L7gu1UUseOL27gipBduk/rIUGry/sj8pzDJE+A CFlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fFEdsCBL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id q11-20020a056a00150b00b0068a692b67b0si5241969pfu.104.2023.10.30.10.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 10:22:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fFEdsCBL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 62450804B01E; Mon, 30 Oct 2023 10:22:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbjJ3RWp (ORCPT + 52 others); Mon, 30 Oct 2023 13:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjJ3RWl (ORCPT ); Mon, 30 Oct 2023 13:22:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21AA48E for ; Mon, 30 Oct 2023 10:22:39 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3550C433C9; Mon, 30 Oct 2023 17:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698686558; bh=q7I+qOPEHdZVE8KeJzEiYinXQQaeltX/0+aK5067TC4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=fFEdsCBLUcvsSFJkrhr1GU5BzwyM5jHTgx65yp4NL73untdVlm7Pb/lcSmo4DNOkq Tkf/pbU2x5r0gkNFCxnTp6FXzMAQWFsbpqO0hUXFQ2NtR0q9A5PJwmFyTBF5jUyGWr i6/BZM0c4uTNUp6vbWADrX3a2smnqHyL67WU90zUf/fj0Yg7jheSYT/VYp/C3Zexn1 jPic36W9/P7fhIbOKw8pMmVXvigD4WIesm3PU4Hn8GSebIraPbZPboaDHpNU4lFcg5 zuLWF/Gp6VuRLK2opPORDOvg84VQzdGxmSLb0txLseT2xX/0RoC4/F63xprDxG1ZH7 re6rDTV6FLL5A== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtw89: fix timeout calculation in rtw89_roc_end() From: Kalle Valo In-Reply-To: <20231024143137.30393-1-dmantipov@yandex.ru> References: <20231024143137.30393-1-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <169868655567.1993746.15704373038382391241.kvalo@kernel.org> Date: Mon, 30 Oct 2023 17:22:37 +0000 (UTC) X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 30 Oct 2023 10:22:45 -0700 (PDT) Dmitry Antipov wrote: > Since 'rtw89_core_tx_kick_off_and_wait()' assumes timeout > (actually RTW89_ROC_TX_TIMEOUT) in milliseconds, I suppose > that RTW89_ROC_IDLE_TIMEOUT is in milliseconds as well. If > so, 'msecs_to_jiffies()' should be used in a call to > 'ieee80211_queue_delayed_work()' from 'rtw89_roc_end()'. > Compile tested only. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. e416514e309f wifi: rtw89: fix timeout calculation in rtw89_roc_end() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231024143137.30393-1-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches