Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Dmitry Antipov <dmantipov@yandex.ru>
CC:     Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH 1/2] wifi: rtlwifi: remove dead code in phy_get_tx_swing_8812A()
Thread-Topic: [PATCH 1/2] wifi: rtlwifi: remove dead code in
 phy_get_tx_swing_8812A()
Thread-Index: AQHaDLfFpHEzB8qQI02jXCHfGystsrBsqVeg
Date:   Mon, 6 Nov 2023 03:37:21 +0000
Message-ID: <e6ae1e6e46d74b3092b28bd17acbefd3@realtek.com>
References: <20231101113510.51290-1-dmantipov@yandex.ru>
In-Reply-To: <20231101113510.51290-1-dmantipov@yandex.ru>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-antivirus-attachment-filter-interceptor-info: license violation
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9
X-KSE-AntiSpam-Interceptor-Info: fallback
X-KSE-Antivirus-Interceptor-Info: fallback
X-KSE-AntiSpam-Interceptor-Info: fallback
X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 05 Nov 2023 19:38:47 -0800 (PST)


> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Wednesday, November 1, 2023 7:35 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; lvc-project@linuxtesting.org; Dmitry
> Antipov <dmantipov@yandex.ru>
> Subject: [PATCH 1/2] wifi: rtlwifi: remove dead code in phy_get_tx_swing_8812A()
> 
> Since 'reg_swing_2g', 'swing_2g', 'reg_swing_5g', and 'swing_5g'
> are compile-time constants, mark all of them as such and remove
> never executed blocks in 'phy_get_tx_swing_8812A()'. Minor style
> adjustments, compile tested only.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  .../wireless/realtek/rtlwifi/rtl8821ae/phy.c  | 77 ++++---------------
>  1 file changed, 16 insertions(+), 61 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> index 5323ead30db0..c262770fea29 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
> @@ -437,12 +437,11 @@ u32 phy_get_tx_swing_8812A(struct ieee80211_hw *hw, u8    band,
>         struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
>         struct rtl_dm *rtldm = rtl_dm(rtlpriv);
>         struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
> -       s8 reg_swing_2g = -1;/* 0xff; */
> -       s8 reg_swing_5g = -1;/* 0xff; */
> -       s8 swing_2g = -1 * reg_swing_2g;
> -       s8 swing_5g = -1 * reg_swing_5g;
> -       u32  out = 0x200;
> -       const s8 auto_temp = -1;
> +       const s8 reg_swing_2g = -1; /* 0xff; */
> +       const s8 reg_swing_5g = -1; /* 0xff; */

Looks like these two can be removed, but I don't really understand what it
wants originally.

> +       const s8 swing_2g = -1 * reg_swing_2g;
> +       const s8 swing_5g = -1 * reg_swing_5g;
> +       u32 out = 0x200;
> 
>         rtl_dbg(rtlpriv, COMP_SCAN, DBG_LOUD,
>                 "===> PHY_GetTXBBSwing_8812A, bbSwing_2G: %d, bbSwing_5G: %d,autoload_failflag=%d.\n",
> @@ -452,36 +451,16 @@ u32 phy_get_tx_swing_8812A(struct ieee80211_hw *hw, u8    band,
>         if (rtlefuse->autoload_failflag) {
>                 if (band == BAND_ON_2_4G) {
>                         rtldm->swing_diff_2g = swing_2g;
> -                       if (swing_2g == 0) {
> -                               out = 0x200; /* 0 dB */
> -                       } else if (swing_2g == -3) {
> -                               out = 0x16A; /* -3 dB */
> -                       } else if (swing_2g == -6) {
> -                               out = 0x101; /* -6 dB */
> -                       } else if (swing_2g == -9) {
> -                               out = 0x0B6; /* -9 dB */
> -                       } else {
> -                               rtldm->swing_diff_2g = 0;
> -                               out = 0x200;
> -                       }
> +                       rtldm->swing_diff_2g = 0;
> +                       out = 0x200;

This branch becomes duplicate assignments of swing_diff_2g. 
    rtldm->swing_diff_2g = swing_2g;
    rtldm->swing_diff_2g = 0;
    out = 0x200;

The original branch chunk might be debug purpose, so maybe add a debugfs entry as
the input of 'swing_2g'. Or, that is used by some boards that don't programmed efuse
but read 'swing_2g' from external file.


It is hard to me to decide if we should take this cleanup.

Ping-Ke