Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Dmitry Antipov <dmantipov@yandex.ru>
CC:     Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: RE: [PATCH 1/2] wifi: rtlwifi: more cleanup for struct rtl_hal
Thread-Topic: [PATCH 1/2] wifi: rtlwifi: more cleanup for struct rtl_hal
Thread-Index: AQHaFkCHTBsHuqTCt0G6N7QDezkgG7B9173Q
Date:   Fri, 17 Nov 2023 03:05:40 +0000
Message-ID: <0dbc9bb6820d4efba40af93f14ef5418@realtek.com>
References: <20231113144734.197359-1-dmantipov@yandex.ru>
In-Reply-To: <20231113144734.197359-1-dmantipov@yandex.ru>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk


> -----Original Message-----
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Sent: Monday, November 13, 2023 10:47 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; linux-wireless@vger.kernel.org; lvc-project@linuxtesting.org; Dmitry
> Antipov <dmantipov@yandex.ru>
> Subject: [PATCH 1/2] wifi: rtlwifi: more cleanup for struct rtl_hal
> 
> Following commit d1e6b020c32d ("wifi: rtlwifi: cleanup struct rtl_hal"),
> remove unused 'hal_coex_8723', 'current_bandtypebackup', 'master_of_dmsp'
> and 'slave_of_dmsp' members of 'struct rtl_hal' as well. Compile tested
> only.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
>  drivers/net/wireless/realtek/rtlwifi/wifi.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/wifi.h b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> index 171a461cd812..33c3e001266f 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/wifi.h
> +++ b/drivers/net/wireless/realtek/rtlwifi/wifi.h
> @@ -1605,7 +1605,6 @@ struct rtl_hal {
>         bool being_init_adapter;
>         bool mac_func_enable;
>         bool pre_edcca_enable;
> -       struct bt_coexist_8723 hal_coex_8723;

In drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hal_btc.c, it does a global
static variable:
   static struct bt_coexist_8723 hal_coex_8723;

That's not a good practice. It would be better to use the field you are removing.
To prevent wasting space, we can dynamically allocate the space when 8723AE
is presented only.

Note, I don't have this old module 8723AE, so even you achieve the patch, 
I can't test it on a real hardware.