Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Kalle Valo <kvalo@kernel.org>
To:     Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     James Prestwood <prestwoj@gmail.com>,
        <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
References: <20231113153544.282461-1-prestwoj@gmail.com>
        <343af05d-eab9-4411-a016-8d7d96f78379@quicinc.com>
Date:   Mon, 20 Nov 2023 11:14:10 +0200
In-Reply-To: <343af05d-eab9-4411-a016-8d7d96f78379@quicinc.com> (Jeff
        Johnson's message of "Thu, 16 Nov 2023 11:24:56 -0800")
Message-ID: <87pm04947x.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 11/13/2023 7:35 AM, James Prestwood wrote:
>> Let ath11k select this option automatically which makes building
>> more intuitive if the user enables this driver (rather than the
>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
>
> s/MICAEL/MICHAEL/
>
> add hard stop
>
> Also suggest you include (or summarize) the information that Kalle
> shared that ath is the outlier here:
>
> Further investigation shows that ath11k and ath12k are the only who use
> 'depends on' with CRYPTO_MICHAEL_MIC:
>
> ./drivers/net/wireless/intel/ipw2x00/Kconfig:	select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/hostap/Kconfig:	select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/orinoco/Kconfig:	select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath11k/Kconfig:	depends on CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath12k/Kconfig:	depends on CRYPTO_MICHAEL_MIC
> ./drivers/staging/rtl8192e/Kconfig:	select CRYPTO_MICHAEL_MIC
> ./drivers/staging/ks7010/Kconfig:	select CRYPTO_MICHAEL_MIC
>
> consider these comments apply to ath12k change as well :)

BTW I can add these changes in the pending branch, no need to resend
because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches