Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <0f79edbc-c727-44b6-8b9e-493026313b83@gmail.com>
Date:   Mon, 20 Nov 2023 04:27:42 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>,
        Jeff Johnson <quic_jjohnson@quicinc.com>
Cc:     linux-wireless@vger.kernel.org
References: <20231113153544.282461-1-prestwoj@gmail.com>
 <343af05d-eab9-4411-a016-8d7d96f78379@quicinc.com>
 <87pm04947x.fsf@kernel.org>
From:   James Prestwood <prestwoj@gmail.com>
In-Reply-To: <87pm04947x.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/20/23 01:14, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>> On 11/13/2023 7:35 AM, James Prestwood wrote:
>>> Let ath11k select this option automatically which makes building
>>> more intuitive if the user enables this driver (rather than the
>>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
>> s/MICAEL/MICHAEL/
>>
>> add hard stop
>>
>> Also suggest you include (or summarize) the information that Kalle
>> shared that ath is the outlier here:
>>
>> Further investigation shows that ath11k and ath12k are the only who use
>> 'depends on' with CRYPTO_MICHAEL_MIC:
>>
>> ./drivers/net/wireless/intel/ipw2x00/Kconfig:	select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/intersil/hostap/Kconfig:	select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/intersil/orinoco/Kconfig:	select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/ath/ath11k/Kconfig:	depends on CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/ath/ath12k/Kconfig:	depends on CRYPTO_MICHAEL_MIC
>> ./drivers/staging/rtl8192e/Kconfig:	select CRYPTO_MICHAEL_MIC
>> ./drivers/staging/ks7010/Kconfig:	select CRYPTO_MICHAEL_MIC
>>
>> consider these comments apply to ath12k change as well :)
> BTW I can add these changes in the pending branch, no need to resend
> because of this.

Works for me. Had a few things come up and hadn't circled back here yet.

Thanks,

James