Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <84dc9e8b-0850-4724-a55b-582c994d042f@lwfinger.net>
Date:   Tue, 21 Nov 2023 16:47:10 -0600
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: EFUSE in RTW8723DS
Content-Language: en-US
To:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Ping-Ke Shih <pkshih@realtek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
References: <f3505110-b76b-4152-8375-37fa3184d3c1@lwfinger.net>
 <748b045e7aaa43eb9a7fb83ad924614f@realtek.com>
 <CAFBinCD=iLbyfWWTqQjLQ5CiqOn08r4UaVqyKHve8AoW_xeFEw@mail.gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <CAFBinCD=iLbyfWWTqQjLQ5CiqOn08r4UaVqyKHve8AoW_xeFEw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/20/23 13:55, Martin Blumenstingl wrote:
> Ping-Ke is right: the eFuse is split into two sections:
> 1. common (RF calibration, EEPROM version, antenna information,
> country code, ...) which is independent of the HCI (host controller
> interface)
> 2. HCI specific bits (PCI vendor/device IDs, USB vendor/device IDs,
> SDIO specifics)
> 
> #1 has already existed for a long time and I didn't have to touch it
> since it's the same for the PCIe, USB and SDIO variant of a wireless
> chip.
> 
> For #2 there are no (known to me) SDIO specific bits other than the
> MAC address. That's why I only added the MAC address for SDIO. If
> there's more it can still be added.
> Note that the MAC address has different offsets depending on whether
> the HCI is PCIe, USB or SDIO.

Martin,

As shown in 
https://github.com/lwfinger/rtw88/issues/157#issuecomment-1820421821, driver 
rtw88 shows a lot worse performance than the vendor driver for a chip with a 
properly encoded EFUSE. Is this not a case of incorrect setting of the 
calibration data?

Larry