Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp1153397rdf; Wed, 22 Nov 2023 07:02:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqUcbQ3s4FtiMc1Mq3YaVpYmsq2lU/BefrJSPOUDrNQNa+YJthYzaaXz6ZHJ5rys9eUD6b X-Received: by 2002:a05:6808:120e:b0:3b6:a8cb:1ecb with SMTP id a14-20020a056808120e00b003b6a8cb1ecbmr3084467oil.40.1700665372779; Wed, 22 Nov 2023 07:02:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700665372; cv=none; d=google.com; s=arc-20160816; b=tOxW8e9G12vf6oyWq4pUVfoG3XLiiTqF2fotQ1qHa3ZLktJGz9ivkxDxkPU45Kc7B3 t/gpaHVYdAOY/9wAJKdH5a6w84kTlYmPg+63WfKnjSnFm7DkQKnT+TuaRtQeNPHgFrSv oTMjWE2ShZzMXFnFSnNs/gIJ7ZZG7s6/ZVaMRWW4LY8Q7/ph8YhthuZvA1dp6z1NkgWl ZImGTQh280mpnBmvPox1xvJUsUsMsgMKRCFt2I90vvc1oJW7t2JgwnSO6NjlnLhNCrPI QBkSA8Wxzf2zZPtgWmWaVlGjkMAJMBzNMRqZofKhA/fqAsOYhV8Uu8EajrE6uEV0XXjC QKbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=1SJUvuhZydQpV3bNha7OWYOezK+97AZ6swSL1+mdIMQ=; fh=jsIpssjyT8bfCaNlWYR6++6VOlBc635mV05LlUs8SzQ=; b=grsOI0XzE54lLEQslbo61bi2t6b+AzehdZu6hqygR4E/EcATbpAs8RvbXNVjJDPsda kEvNktmkPivVNsJ3D1OwWlWkWmVEIGMWc0DNXnsS4j2ozim9DCF3slsii6yi4OsEhZWf 2rTpVhsnVCKGZE9Imns6Ez6LrTGKQ/S3VdIeea4LV87ZgJ9QLSV6Tu0duPN7VfTUobDc R8szBd2tZATDmwemMfY5UGfd9nL36ctAL5uWeyD5PlvCKbvvj3vkwN/rGziAldO4q66+ wwmTH+U3yugwZasa6ImwtywSwedBon0ZoglyGaekL0CIAaVbYrXndvZvpOfJ3BWxr9px PeYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kJlUETFp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id q9-20020a056808200900b003b833fa6685si1411392oiw.332.2023.11.22.07.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 07:02:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kJlUETFp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8E21F8227415; Wed, 22 Nov 2023 07:02:43 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235047AbjKVPCo (ORCPT + 53 others); Wed, 22 Nov 2023 10:02:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232793AbjKVPCo (ORCPT ); Wed, 22 Nov 2023 10:02:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE24B19D for ; Wed, 22 Nov 2023 07:02:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B083C433CB; Wed, 22 Nov 2023 15:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700665360; bh=xWXFnQCVaUKviWVPS8uh+T0RISysTFHCzWBP1f/x/V4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kJlUETFpGjyViEyQtz0FVV+pfBiJJUMAOcHqV8TLAIrCeKKgdK201H/GVNTeoKg9H 7SecfujVr5yV9ChfwUW1OQ4+ehOxK2l5weq3OHNnQ7b5KcmVlAo23qadkV674fVqlA thhIgm89wq+SMVncw943OXIhO8nFRZgbzWvMBxJu2MIiV6bWlPoYjl9VHtjVTCipSe DH1nHIGNbNAsUzHQp5ilNJudz5JCTzhCjUmfvXfKW5+yqghK9L46ohiSY+hx5J/EKx mF8KwxsYEy7UkqsscvFuV6GSn67HYPFUJ2YlJ3hIzKLF0GDbAm52jhcKXMyAKxS2VT kcgWd+XQgnR5g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 2/2] wifi: rtlwifi: simplify rtl_action_proc() and rtl_tx_agg_start() From: Kalle Valo In-Reply-To: <20231113144734.197359-2-dmantipov@yandex.ru> References: <20231113144734.197359-2-dmantipov@yandex.ru> To: Dmitry Antipov Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org, Dmitry Antipov User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170066535717.4178710.17154753836548581473.kvalo@kernel.org> Date: Wed, 22 Nov 2023 15:02:39 +0000 (UTC) X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 22 Nov 2023 07:02:43 -0800 (PST) Dmitry Antipov wrote: > Since 'drv_priv' is an in-place member allocated at the end of > 'struct ieee80211_sta', it can't be NULL and so relevant checks > in 'rtl_action_proc()' and 'rtl_tx_agg_start()' may be dropped. > Compile tested only. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Dmitry Antipov > Acked-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 2c4e9acbe3a5 wifi: rtlwifi: simplify rtl_action_proc() and rtl_tx_agg_start() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231113144734.197359-2-dmantipov@yandex.ru/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches