Received-SPF: pass (google.com: domain of linux-wireless+bounces-60-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <bc97ce4621415537ce181b23a6f07a4eda385f6f.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: cfg80211: Rename bssid to peer_addr in
 cfg80211_pmksa
From: Johannes Berg <johannes@sipsolutions.net>
To: Anuj Khera <quic_akhera@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Date: Fri, 24 Nov 2023 18:35:43 +0100
In-Reply-To: <20231120062450.8023-1-quic_akhera@quicinc.com>
References: <20231120062450.8023-1-quic_akhera@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-11-20 at 11:54 +0530, Anuj Khera wrote:
> The cfg80211_pmksa structure uses bssid member to store
> the PMKSA for a BSS in Station mode. Change the name of
> structure member bssid to peer_addr so that same member
> can be used to store the PMKSA for a station in AP mode
> using station MAC address.
>=20
> Signed-off-by: Anuj Khera <quic_akhera@quicinc.com>
> ---

Please tag your patches with a version, and document the changes between
them.

>   *
> - * @bssid: The AP's BSSID (may be %NULL).
> + * @peer_addr: The AP's BSSID (may be %NULL) in case of Station mode. Th=
e STA's
> + *      mac address (may be %NULL) in case of AP mode.
>=20

"MAC address", I guess?

And the "may be %NULL" really makes zero sense in AP mode, who are you
going to have the entry for?!

It barely even makes sense in client mode.

johannes