Received-SPF: pass (google.com: domain of linux-wireless+bounces-63-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <1a2ada781ce53e8f1d9c85de44780ee895443c3f.camel@sipsolutions.net>
Subject: Re: [PATCH v3 1/1] wifi: nl80211: Add PTK/GTK rekey interval
 attributes for APs supporting PSK offload
From: Johannes Berg <johannes@sipsolutions.net>
To: Jithu Jance <jithu.jance@broadcom.com>
Cc: linux-wireless@vger.kernel.org, vinayak.yadawad@broadcom.com
Date: Fri, 24 Nov 2023 20:03:02 +0100
In-Reply-To: <20231113124742.13588-1-jithu.jance@broadcom.com>
References: <20231113124742.13588-1-jithu.jance@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-11-13 at 18:17 +0530, Jithu Jance wrote:
> This patch adds attributes to NL80211_CMD_START_AP that the user applicat=
ion
> can use to pass down PTK/GTK rekey interval times to the driver. If drive=
r can't
> support the configuration, it is expected to return failure to NL8011_CMD=
_START_AP.

That doesn't work, _all_ current drivers will obviously completely
ignore this setting. If you need that behaviour, you need to add new
feature flags for it.

> +		if (info->attrs[NL80211_ATTR_PTK_REKEY_INTERVAL])
> +			settings->ptk_rekey_interval =3D nla_get_u32(info->attrs[NL80211_ATTR=
_PTK_REKEY_INTERVAL]);
> +		else
> +			settings->gtk_rekey_interval =3D nla_get_u32(info->attrs[NL80211_ATTR=
_GTK_REKEY_INTERVAL]);
>=20

Why can you not set both at the same time?! That should be documented,
if it's really desired, but that seems really counter-intuitive?

johannes