Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1614587rdh; Fri, 24 Nov 2023 18:40:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEsqLOsvyRuuUbCL1Llg8h8/0Ii0xcx0TB0FknUF4LczU+XBY0ckOvGUVRjFVNCKlXPRQAd X-Received: by 2002:ad4:48d3:0:b0:66d:2aa3:cd49 with SMTP id v19-20020ad448d3000000b0066d2aa3cd49mr4354915qvx.14.1700880040522; Fri, 24 Nov 2023 18:40:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700880040; cv=none; d=google.com; s=arc-20160816; b=CZ04vIFhgjkcUgmUWLMt3KE8FFrxIW8pyqzfN9uarvEl8uTzosJhpHxMVwF+ohdNb5 tyc2RIaiSWkz9wFhtGWk1nPBnPXFSW3PKqtGHESppuav+xmuzCQjLqDdFcmW8+rcoViX +Dr7Zs9A5fOgVMh5c8s/RWBIdEdvy1mlDxVyhi1XjG3o+eP7Hr9J2BhbGVq+CI3e5Mm9 oPEFYaDUBStyns5PIwFzOcwuiIeEAeRXVkx5beHT7nZa0hRcX4iEOd1tukoxvyd5fqF6 Tr+dUe2tSOh2W2yp/dsnIFsT59oGtv8tQ91aeYaHgkB1RWXyL/IAZsyB2PBwONEslnWB ANSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=HQaKyi0B71ei0sjRzHS90hU6RIYmUyqbs52s4MkWRLE=; fh=NHHKh4qhr8L174fW3ibEmcf8ANJKvOJt27th/1X022k=; b=O2igno0w2tw6xdn1Y3ZQn19/ZSIPlJWpo5w90+YjUVE/I81k+lwoDlUtiM3AkNzxb1 2u0m61txF1RWi8DTXjZ4qjTADWdS/m2UUbV7mZCZEkGeIhuW8CqbVizU7BmwM38QJTFv ckCntAFrE0+iUyHER64Fy13sLLJShwACxEA6KhLAcE85txVptgugS+Q7PrrJP1IEBiJB hPjvzxhTjP/6DN9YvNqjAfufgMPLJvfveDpMt03PO660OgAdWVm+BoVBlXlAJXTjkWug LCldQSx4LAmuqfMFw1nLZoHQ+Ebl4wm88qHHJGc5KL06DktkNpOmPT/0UKYwbKxIvG2O mq8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=eUJq3iGj; spf=pass (google.com: domain of linux-wireless+bounces-69-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-69-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dm7-20020ad44e27000000b0067a268dee2csi487808qvb.178.2023.11.24.18.40.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 18:40:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-69-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=eUJq3iGj; spf=pass (google.com: domain of linux-wireless+bounces-69-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-69-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3988D1C20925 for ; Sat, 25 Nov 2023 02:40:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 80E1F138A; Sat, 25 Nov 2023 02:40:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eUJq3iGj" X-Original-To: linux-wireless@vger.kernel.org Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02905E1 for ; Fri, 24 Nov 2023 18:40:33 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a03a900956dso474395166b.1 for ; Fri, 24 Nov 2023 18:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1700880031; x=1701484831; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HQaKyi0B71ei0sjRzHS90hU6RIYmUyqbs52s4MkWRLE=; b=eUJq3iGj3kc/snsUqM88rIhweP0+Dxk7HBpB++YsCigjIrSEK0bwp2GpGU1vG0yhcL 35uPMV+pYeD1M+L9OXs/sX4EIx+BiBGLk+/uU8IBvMdGFtCjiJ5+5uL8vGg8idrkCjKz I8IZEwiHCf9rDEC49HNoN9ZZC8eqFWVq4/7oQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700880031; x=1701484831; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HQaKyi0B71ei0sjRzHS90hU6RIYmUyqbs52s4MkWRLE=; b=lbvd9pnW5+uKzKj1mY9eHxd0np6SMd8sRAFhAHR4eBw2e55q5jFsl5kuLih3ujzMOu xVsL74Sskwo6UUKeAWmRpiSCiXV1jcsJtEPc/9FP0JaWTfZbcyY0GxK3WjtW87FcCOyz bModL/kR+JQX1Ls6q6O3BPERqZeDku7zRwSRj0tXCXQ3w6Nxe3OyjvZe6czBULGqTMT5 v9HJFrl8lUNpYHoheTlPad/DJIDVTZsJeTn8Gmny7bpk/247gmn+Hx1A2/bxyzOyTFwe /Kfvt/UNT/JCJHfM8UxIOjYpnxi5Z60TK0Cktdv2qmYrny9BGAJJD6+kcIxpw4puyMAw T00g== X-Gm-Message-State: AOJu0YwQNJUBQmUqnLW7EXSvL15d0gUkzT4DCjhqQOPbMxvZXTIjR4XM 1eW6QEkKSNmxtLYwjVcYktMcLCZt6fuzUcdi9YQhZQ== X-Received: by 2002:a17:906:20d8:b0:9fa:5594:4e94 with SMTP id c24-20020a17090620d800b009fa55944e94mr4150844ejc.27.1700880031354; Fri, 24 Nov 2023 18:40:31 -0800 (PST) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231113124742.13588-1-jithu.jance@broadcom.com> <1a2ada781ce53e8f1d9c85de44780ee895443c3f.camel@sipsolutions.net> In-Reply-To: <1a2ada781ce53e8f1d9c85de44780ee895443c3f.camel@sipsolutions.net> From: Jithu Jance Date: Sat, 25 Nov 2023 08:10:18 +0530 Message-ID: Subject: Re: [PATCH v3 1/1] wifi: nl80211: Add PTK/GTK rekey interval attributes for APs supporting PSK offload To: Johannes Berg Cc: linux-wireless@vger.kernel.org, vinayak.yadawad@broadcom.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000190652060af0fe34" --000000000000190652060af0fe34 Content-Type: multipart/alternative; boundary="000000000000136688060af0fe06" --000000000000136688060af0fe06 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable >That doesn't work, _all_ current drivers will obviously completely ignore this setting. Got your point - without this user space will not be sure whether GTK/PTK will work with the driver even though values are passed down. Will add it. >Why can you not set both at the same time?! Yes, agree. will fix it. *Jithu Jance * On Sat, Nov 25, 2023 at 12:33=E2=80=AFAM Johannes Berg wrote: > On Mon, 2023-11-13 at 18:17 +0530, Jithu Jance wrote: > > This patch adds attributes to NL80211_CMD_START_AP that the user > application > > can use to pass down PTK/GTK rekey interval times to the driver. If > driver can't > > support the configuration, it is expected to return failure to > NL8011_CMD_START_AP. > > That doesn't work, _all_ current drivers will obviously completely > ignore this setting. If you need that behaviour, you need to add new > feature flags for it. > > > + if (info->attrs[NL80211_ATTR_PTK_REKEY_INTERVAL]) > > + settings->ptk_rekey_interval =3D > nla_get_u32(info->attrs[NL80211_ATTR_PTK_REKEY_INTERVAL]); > > + else > > + settings->gtk_rekey_interval =3D > nla_get_u32(info->attrs[NL80211_ATTR_GTK_REKEY_INTERVAL]); > > > > Why can you not set both at the same time?! That should be documented, > if it's really desired, but that seems really counter-intuitive? > > johannes > --000000000000136688060af0fe06 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>That doesn't work, _all_ curren= t drivers will obviously completely
ignore this setting.
<= div dir=3D"ltr">
Got your point - without this user space will no= t be sure whether GTK/PTK will work with the driver even though values are = passed down. Will add it.


>Why can you not se= t both at the same time?!
Yes, agree. will fix it.
Jithu Jance=C2=A0


On Sat, Nov 25, 2023 at 12:33=E2=80=AFAM Johannes Be= rg <johannes@sipsolutions.n= et> wrote: