Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp1902454rdh; Sat, 25 Nov 2023 06:48:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjWR8sPeFQSpv4RIMYQBeTGnN6Ydby7DJmwL5zJ8RLrzmWTwZSiaJJCj3/oIsqoWioy8Bo X-Received: by 2002:a17:902:d68b:b0:1cf:6e3c:a3e7 with SMTP id v11-20020a170902d68b00b001cf6e3ca3e7mr6793219ply.11.1700923720018; Sat, 25 Nov 2023 06:48:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700923720; cv=none; d=google.com; s=arc-20160816; b=B8SaBt0E+38SVYg7itGxTCUzVWhg3AZfHEbCRtJnWYOBAv3Bn0DFTkWa/MmryROs2j M9+Nt8ikdF1p1S8LgjFK44v+AqabXcIwrWkmr3z/OSv2LcSM6LWUgB5t0iZNpBuwqn6A lVsEEIxZKP6lCSWN6CMwqYq0nOgj5nLyckutW6tUaZIjEUEusDwKOJopiwQ2tAyoEg4T GZ/W1CqIeKXKX+Jz+wqLbYBUrxmhhDbqwWw2m650j/f5el494En+MlawfEGme757dh4/ ql+8syWzktu47G3p3jAZHidHnca5Ccturyl/2hyw4uz546MFeEQorEUGBWBZzngnlOEP e/Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xUbeFBAucQ/oAkWN5ZD4CELZkrzDMyoUvt/g7lxklO0=; fh=dfzOq4qcnRfKKTKOuaMHD5uGtQHsCafIKfAaIMDBrjs=; b=ncwgL2WOkkQLOzFgx5P9SHk0Z6Md7Qg+53mhxlWH1oZ9Rvex3HJ3yxMwOKnZjKJFE8 yW9gaACRjw11Dig1FQPF60b++7JEc1W9QpFPbZtHapUV5epX26LZ5FZ297m1Ic5RWr+l T6geHF48XEfgVDl1yapHz0DApFWHoWItDVnfArH4PhkGgTQ9GrHlR/bG7j66Mthz28EY 0SM3sQgbxJAGw2fH4h1QDe3Shc3Cr2N/a4nDGbczFb7peCXuKu3ZEQ6dcJ6TfXH3hil/ DbMmmSUJ+7//DMjdPJLTNFKPwSCz1sfJLVOKP3UV8p79idHStR+5ciHjd1OqEtSRFG0S pBSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ked7JVe5; spf=pass (google.com: domain of linux-wireless+bounces-73-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-73-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id lk14-20020a17090308ce00b001c427a74e31si5931839plb.628.2023.11.25.06.48.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Nov 2023 06:48:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-73-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ked7JVe5; spf=pass (google.com: domain of linux-wireless+bounces-73-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-73-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8A6E72813BE for ; Sat, 25 Nov 2023 14:48:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B93BD301; Sat, 25 Nov 2023 14:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ked7JVe5" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10E3518045 for ; Sat, 25 Nov 2023 14:48:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29007C433C8; Sat, 25 Nov 2023 14:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1700923717; bh=Bu5//kjJspOiaXvzhiIPwduKqA4hrH4OAkkljNG/AaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ked7JVe5kebzJGTY4cwvgKzVwjTYL4K0cZzOyNsRyZvd9PZ+VrOXyQicw9+r9YuN3 SPPCZsbL4uNEy3c6tk/z16BT9nkCozZYhzMwCbZUa5kYhPb/vc3gra+vTDb+JpYiwc 3sIJYjyazGkm+gNyG0Tpio2259t6lvOIH2Uj0LAk= Date: Sat, 25 Nov 2023 14:48:34 +0000 From: Greg Kroah-Hartman To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Johannes Berg Subject: Re: [PATCH v2 2/6] debugfs: annotate debugfs handlers vs. removal with lockdep Message-ID: <2023112530-eraser-glare-44b2@gregkh> References: <20231124162522.16344-7-johannes@sipsolutions.net> <20231124172522.0442774abc66.Ia70a49792c448867fd61b0234e1da507b0f75086@changeid> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124172522.0442774abc66.Ia70a49792c448867fd61b0234e1da507b0f75086@changeid> On Fri, Nov 24, 2023 at 05:25:25PM +0100, Johannes Berg wrote: > From: Johannes Berg > > When you take a lock in a debugfs handler but also try > to remove the debugfs file under that lock, things can > deadlock since the removal has to wait for all users > to finish. > > Add lockdep annotations in debugfs_file_get()/_put() > to catch such issues. > > Signed-off-by: Johannes Berg Acked-by: Greg Kroah-Hartman