Received-SPF: pass (google.com: domain of linux-wireless+bounces-82-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <dffcbd379ede949e328076c5cffb42d442f0ba9a.camel@sipsolutions.net>
Subject: Re: [PATCH 4/6] wifi: cfg80211: Schedule regulatory check on BSS
 STA channel change
From: Johannes Berg <johannes@sipsolutions.net>
To: "Otcheretianski, Andrei" <andrei.otcheretianski@intel.com>, "Greenman,
	Gregory" <gregory.greenman@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Date: Sun, 26 Nov 2023 14:19:48 +0100
In-Reply-To: <DM6PR11MB3897EAD2252F23EBAED8EC4EF5BEA@DM6PR11MB3897.namprd11.prod.outlook.com>
References: <20231113093505.456824-1-gregory.greenman@intel.com>
	 <20231113112844.15d7a0ee3fda.I1879d259d8d756159c8060f61f4bce172e6d323e@changeid>
	 <782a4f7ac91dcb0e1c564e285051c63e2a95d71f.camel@sipsolutions.net>
	 <DM6PR11MB3897EAD2252F23EBAED8EC4EF5BEA@DM6PR11MB3897.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

>=20
> >=20
> > > +void cfg80211_schedule_channels_check(struct net_device *netdev) {
> > > +	struct wireless_dev *wdev =3D netdev->ieee80211_ptr;
> > > +	struct wiphy *wiphy =3D wdev->wiphy;
> > > +
> > > +	/* Schedule channels check if NO_IR or DFS relaxations are
> > supported */
> > > +	if (wdev->iftype =3D=3D NL80211_IFTYPE_STATION &&
> > > +	    (wiphy_ext_feature_isset(wiphy,
>=20
> We do need wdev here,=C2=A0
>=20

Oh right, I missed that, sorry.

> I will change it to be wireless device instead
>=20

No need I guess, if we're only going to check for it being a station?
Would we ever have a reason to call this for a p2p/nan device? I guess
not, since that doesn't affect regulatory in the same way?

johannes