Received-SPF: pass (google.com: domain of linux-wireless+bounces-130-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0f2e4781cbc994bacae6fe8f56b9aef9fc66bc1a.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: use __counted_by for the rest of
 flexible array members
From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>, 
	linux-wireless@vger.kernel.org
Date: Mon, 27 Nov 2023 22:16:50 +0100
In-Reply-To: <20231127112601.42636-1-dmantipov@yandex.ru>
References: <20231127112601.42636-1-dmantipov@yandex.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-11-27 at 14:25 +0300, Dmitry Antipov wrote:
> Following commit 9118796dfa67 ("wifi: mac80211: Add __counted_by for stru=
ct
> ieee802_11_elems and use struct_size()"), use an incoming '__counted_by()=
'
> attribute for the flexible array members of 'struct probe_resp', 'struct
> fils_discovery_data', 'struct unsol_bcast_probe_resp_data', 'struct
> ieee80211_mgd_auth_data' and 'struct ieee80211_mgd_assoc_data', as well a=
s
> 'struct_size()' helper to allocate an instances of them where appropriate=
.
> This also introduces reordering of statements in 'ieee80211_mgd_auth()'
> and 'ieee80211_mgd_assoc()' because the counter field should (is better
> to?) be adjusted before touching the corresponding '__counted_by()' area.

For the record, regardless of the commments from Gustavo, I'm going to
put this on the back of the list because we have various things in
flight now that touch these areas, particularly mgd_auth/mgd_assoc and
related code. Not convinced that it's worth making more work on other
things for this, when I don't even think (released) compilers have
support yet.

So just FYI, you might want to come back with this in a month or two
when hopefully other things have settled.

johannes