Received-SPF: pass (google.com: domain of linux-wireless+bounces-133-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 27 Nov 2023 16:22:11 -0800
From: Kees Cook <keescook@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dmitry Antipov <dmantipov@yandex.ru>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Will Deacon <will@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] uapi: propagate __struct_group() attributes to the
 container union
Message-ID: <202311271620.B0CB21B@keescook>
References: <20231120110607.98956-1-dmantipov@yandex.ru>
 <f0bebfe0f7e02bb51676d8f6a80be0444e2b8662.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0bebfe0f7e02bb51676d8f6a80be0444e2b8662.camel@sipsolutions.net>

On Fri, Nov 24, 2023 at 06:37:14PM +0100, Johannes Berg wrote:
> On Mon, 2023-11-20 at 14:05 +0300, Dmitry Antipov wrote:
> > Recently the kernel test robot has reported an ARM-specific BUILD_BUG_ON()
> > in an old and unmaintained wil6210 wireless driver.
> > 
> 
> Heh. I guess it wasn't unmaintained enough for someone to touch it and
> add struct_group() to it...

It needed it since it was using memcpy across fields. But it's been a
while since that change happened, so finding this bug now is pretty
impressive. :)

> 
> >  include/uapi/linux/stddef.h | 2 +-
> > 
> 
> No idea what tree this should go through, but I guess wireless isn't
> appropriate.

I'll take it; thanks for the find Dmitry!

-- 
Kees Cook