Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3943138rdh; Tue, 28 Nov 2023 07:48:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHun2p2LylmqxybvYw9pGJnqHwGraNdzM9JTxUkM2+eZR3UR9n7JJziVgwIcIZMNb/CjeOp X-Received: by 2002:a05:6a20:94cc:b0:18b:b02d:8b6 with SMTP id ht12-20020a056a2094cc00b0018bb02d08b6mr17147111pzb.23.1701186509696; Tue, 28 Nov 2023 07:48:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701186509; cv=none; d=google.com; s=arc-20160816; b=fJG8Jki5+XPqCZbKmVM6GIX2lmDBfy75xJ/3A+TDFWxOnVzcJbDrlj7Tux4ei9y8ML zbuVZcyHT3RtM4aBu7IEqHgEtW71F6YL/FNmbTpHIFiXMMUaaAdwUi7MvitwldXkHC7G qiE1OxH0ASswaNihhylNmSsTOsekaBDCh9rVDi9ofe0EdL1EpKeWBxpRtq4/rPFMEgCw 0Qe/LTGs/5oAKuydMpo5d5biCOnLEypTr6tcGRoMvUrkQfIF1gH1+cCXrVrxHcUCy2kf z7jjSD+6g3rmJUIpJb8eg4ZIB7NQ6qxEU1eAU9fJBhhnS1qb9dHuFDmkZvkZ5nuI9zyy jY4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature:dkim-filter; bh=V7525ZrKa7e1c1VVfAyh3vSRcoYx2KTXdbAZtozwMkc=; fh=rBNoyYcK2gKpJnJjDLXVVgGvmA6hCQsjUGRc8T1tpKI=; b=e6foV3jawQM+zCVl1CEjcqiQFA7rq+qU6RjbFhvEM9vZUSfyMxl3KuIznfoDoZYdUg zb+Soe7DtqxrkiMPKKaXwWO5nOvbUxIRrkKSsA+l9XsBjglb8VImjU727uGSkP0H1JWC oqEcnWfZ/6HwfixcJkPhT3IlF17aF3l5SaUcOlYCi1lSEdwHJwQ6S1K30biqziM3yiKG 9hnijfXxO3naFA5ZHRjtGd5t5/IHbhtxVVhAvIXlVGPlFMKfiEy/jcIEK/claR+mWip0 d8lB2FtnlAdoHtrb0fa2MRCcB62fdQfxrGbiHC6YzFN6dieo6lR+LdseoxsSfjQPgp7V f/tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="jUYSL/xO"; spf=pass (google.com: domain of linux-wireless+bounces-170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id cf2-20020a056a02084200b005c278e32054si11454069pgb.677.2023.11.28.07.48.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 07:48:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b="jUYSL/xO"; spf=pass (google.com: domain of linux-wireless+bounces-170-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-170-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6F910B20E51 for ; Tue, 28 Nov 2023 15:48:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC3B51E4AF; Tue, 28 Nov 2023 15:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=candelatech.com header.i=@candelatech.com header.b="jUYSL/xO" X-Original-To: linux-wireless@vger.kernel.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22F0A131; Tue, 28 Nov 2023 07:48:19 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id DCCB76C006B; Tue, 28 Nov 2023 15:48:15 +0000 (UTC) Received: from [192.168.100.159] (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 38FE813C2B0; Tue, 28 Nov 2023 07:48:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 38FE813C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1701186494; bh=Yixl1xyYwD8kSDiWpTPtI5+afOqah48uBPD+KUU1vdA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jUYSL/xO/6AROAbiVhpkla/xoSlLqxATnKuyWcg8R/tSSCP/kZ8LL1YNZCedeVZ6r RGMtxwGqHshkalpe9iXJHTlHohCElKuoODppOle1FYUg3txO5jRLVQ40ZEHc4NBSiS PC6iQk1Ffgx+Z0ARnrBjZFz9X2i8I/6kBkX+//aY= Message-ID: <7979003a-6aa2-9af7-a3cf-d946c8e47a15@candelatech.com> Date: Tue, 28 Nov 2023 07:48:13 -0800 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 0/6] fixes for debugfs/wireless locking issue Content-Language: en-US To: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" References: <20231124162522.16344-7-johannes@sipsolutions.net> From: Ben Greear Organization: Candela Technologies In-Reply-To: <20231124162522.16344-7-johannes@sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MDID: 1701186497-o-mBe0zcfep9 X-MDID-O: us5;at1;1701186497;o-mBe0zcfep9;;491d5e7d29372e7e6a6a119117ca0c86 On 11/24/23 08:25, Johannes Berg wrote: > There's a locking issue in wireless where it takes a lock inside > a debugfs file handler that's also taken around the removal of > the debugfs file, and this causes a deadlock due to the proxy > object use. Fixing the debugfs removal is tricky because some > of the objects represented there fundamentally are deleted with > the lock held. Not taking the lock in the debugfs file is also > not really the right thing to do. Therefore, right now, the only > way to fix this would be to not have the debugfs files entirely, > but that isn't really helpful either. I have been running the RFC series and haven't noticed problems, so you can add: Tested-by: Ben Greear Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com