Received-SPF: pass (google.com: domain of linux-wireless+bounces-171-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 28 Nov 2023 11:37:35 -0600
From: Rob Herring <robh@kernel.org>
To: Peter Chiu <chui-hao.chiu@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, Ryder Lee <ryder.Lee@mediatek.com>, Evelyn Tsai <evelyn.tsai@mediatek.com>, Shayne Chen <shayne.chen@mediatek.com>, Sam Shih <sam.shih@mediatek.com>, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: wireless: mt76: add interrupts
 description for MT7986
Message-ID: <20231128173735.GA3537931-robh@kernel.org>
References: <20231128035723.5217-1-chui-hao.chiu@mediatek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231128035723.5217-1-chui-hao.chiu@mediatek.com>

On Tue, Nov 28, 2023 at 11:57:23AM +0800, Peter Chiu wrote:
> The mt7986 can support four interrupts to distribute the interrupts
> to different CPUs.
> 
> Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
> ---
>  .../bindings/net/wireless/mediatek,mt76.yaml  | 24 +++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index 252207adbc54..20f5f2ead265 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -19,9 +19,6 @@ description: |
>    Alternatively, it can specify the wireless part of the MT7628/MT7688
>    or MT7622/MT7986 SoC.
>  
> -allOf:
> -  - $ref: ieee80211.yaml#
> -
>  properties:
>    compatible:
>      enum:
> @@ -38,7 +35,8 @@ properties:
>        MT7986 should contain 3 regions consys, dcm, and sku, in this order.
>  
>    interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 4
>  
>    power-domains:
>      maxItems: 1
> @@ -219,6 +217,24 @@ required:
>  
>  unevaluatedProperties: false
>  
> +allOf:
> +  - $ref: ieee80211.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7986-wmac
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 1
> +          items:
> +            - description: major interrupt for rings
> +            - description: addditional interrupt for ring 19
> +            - description: addditional interrupt for ring 4
> +            - description: addditional interrupt for ring 5

This list belongs in the top level. The if/then schema needs to set 
'maxItems: 1' for the cases with only 1 interrupt and 'minItems: 4' for 
the cases with 4 interrupts.

Rob