Received-SPF: pass (google.com: domain of linux-wireless+bounces-172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1c37d99f722f891a50c540853e54d4e36bdf0157.camel@sipsolutions.net>
Subject: Re: [RFC PATCH] wifi: cfg80211: fix CQM for non-range use
From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Walle <mwalle@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, 
	linux-wireless@vger.kernel.org, Max Schulze <max.schulze@online.de>
Date: Tue, 28 Nov 2023 19:23:18 +0100
In-Reply-To: <202311090752.hWcJWAHL-lkp@intel.com>
References: <202311090752.hWcJWAHL-lkp@intel.com>
	 <202311090752.hWcJWAHL-lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2023-11-28 at 15:44 +0100, Michael Walle wrote:
> Hi,
>=20
> > net/wireless/nl80211.c: In function 'nl80211_set_cqm_rssi.isra':
> > net/wireless/nl80211.c:12892:17: warning: 'memcpy' specified bound
> > 18446744073709551615 exceeds maximum object size 9223372036854775807
> > [-Wstringop-overflow=3D]
>=20
> FWIW, I'm getting the same error with the current next (next-20231128).
>=20

I actually forgot about that, but does anyone actually know what this is
trying to tell me?

The code seems to be

        if (n_thresholds) {
                cqm_config =3D kzalloc(struct_size(cqm_config, rssi_thresho=
lds,
                                                 n_thresholds),
                                     GFP_KERNEL);
                if (!cqm_config)
                        return -ENOMEM;

                cqm_config->rssi_hyst =3D hysteresis;
                cqm_config->n_rssi_thresholds =3D n_thresholds;
                memcpy(cqm_config->rssi_thresholds, thresholds,
                       flex_array_size(cqm_config, rssi_thresholds,
                                       n_thresholds));


Or does it just want to say n_thresholds shouldn't be a signed variable?

johannes