Received-SPF: pass (google.com: domain of linux-wireless+bounces-195-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <tencent_DE78F66DB82F496F9894B8E826EC8ACE0C0A@qq.com>
From: Edward Adam Davis <eadavis@qq.com>
To: johannes@sipsolutions.net
Cc: davem@davemloft.net,
	eadavis@qq.com,
	edumazet@google.com,
	kuba@kernel.org,
	linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org,
	llvm@lists.linux.dev,
	nathan@kernel.org,
	ndesaulniers@google.com,
	netdev@vger.kernel.org,
	pabeni@redhat.com,
	syzbot+62d7eef57b09bfebcd84@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com,
	trix@redhat.com
Subject: Re: [PATCH] wifi: mac80211: sband's null check should precede params
Date: Wed, 29 Nov 2023 16:18:19 +0800
In-Reply-To: <6c7765f13b715e67637438c6dffaa5a369758519.camel@sipsolutions.net>
References: <6c7765f13b715e67637438c6dffaa5a369758519.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Wed, 29 Nov 2023 07:57:07 +0100, Johannes Berg wrote:
> > [Analysis]
> > When ieee80211_get_link_sband() fails to find a valid sband and first checks
> > for params in sta_link_apply_parameters(), it will return 0 due to new_link
> > being 0, which will lead to an incorrect process after sta_apply_parameters().
> >
> > [Fix]
> > First obtain sband and perform a non null check before checking the params.
> 
> Not sure I can even disagree with that analysis, it seems right, but ...
> 
> > +	if (!link || !link_sta)
> > +		return -EINVAL;
> > +
> > +	sband = ieee80211_get_link_sband(link);
> > +	if (!sband)
> > +		return -EINVAL;
> > +
> >  	/*
> >  	 * If there are no changes, then accept a link that doesn't exist,
> >  	 * unless it's a new link.
> 
> There's a comment here which is clearly not true after this change,
> since you've already returned for !link_sta?
No, after applying my patch, it will return due to !sband.

Edward