Received-SPF: pass (google.com: domain of linux-wireless+bounces-218-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <2bd104e1-2cd1-48dc-849f-e56678eca2fc@gmail.com>
Date: Wed, 29 Nov 2023 04:22:45 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] wifi: ath10k: add support to allow broadcast action
 frame RX
Content-Language: en-US
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org
References: <20231116173246.40458-1-prestwoj@gmail.com>
 <170125916304.1282598.27815217329600631.kvalo@kernel.org>
From: James Prestwood <prestwoj@gmail.com>
In-Reply-To: <170125916304.1282598.27815217329600631.kvalo@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Kalle,

On 11/29/23 03:59, Kalle Valo wrote:
> James Prestwood <prestwoj@gmail.com> wrote:
>
>> Broadcast action frames are needed for the Device Provisioning
>> Protocol (DPP) for Presence and PKEX Exchange requests. Currently
>> just ath9k has this capability so this is being enabled for
>> ath10k (for at least one hardware variant).
>>
>> Add a new capability flag in ath10k_hw_params to indicate support
>> for receiving multicast action frames. This bit is then checked
>> when configuring the RX filter and (if set) multicast action frame
>> registration is enabled.
>>
>> Until more hardware can be tested only the "qca6174 hw3.2" variant
>> is enabling this feature.
>>
>> Note: I went ahead and removed the 'changed_flags' mask operation
>> since it had no effect, that parameter was not being used anywhere.
>>
>> Tested-on: QCA6174 hw3.2 WLAN.RM.4.4.1-00288-
>>
>> Signed-off-by: James Prestwood <prestwoj@gmail.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> This had a simple conflict in ath10k_configure_filter() and I fixed it in the
> pending branch, please check:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=cc9f5dfd74f93ae6f596bccc3a5b92fe3f18c439
>
> In the future please use ath.git master branch as the baseline for ath driver patches.

Thank you for resolving that, and I'll use ath.git in the future.

Thanks,

James