Received-SPF: pass (google.com: domain of linux-wireless+bounces-227-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <c76148d0-d5da-4c64-b080-8147b5491946@amd.com>
Date: Wed, 29 Nov 2023 11:26:29 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v14 3/9] cfg80211: expose nl80211_chan_width_to_mhz for
 wide sharing
Content-Language: en-US
To: Ma Jun <Jun.Ma2@amd.com>, amd-gfx@lists.freedesktop.org, lenb@kernel.org,
 hdegoede@redhat.com, johannes@sipsolutions.net, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
 alexander.deucher@amd.com, Lijo.Lazar@amd.com, netdev@vger.kernel.org,
 linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org
Cc: majun@amd.com, Evan Quan <quanliangl@hotmail.com>
References: <20231129091348.3972539-1-Jun.Ma2@amd.com>
 <20231129091348.3972539-4-Jun.Ma2@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20231129091348.3972539-4-Jun.Ma2@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RU5SUWprQnloSmdJSG9pYndDV0piN3RZUjBlVG1iRGF6ZEtMQS9EMHdvd0l4?=
 =?utf-8?B?L0doYU1PcnRLcHQyVkl5L1dMWG9SLzkyV1k1OGFDaWYxMkhzYVd2d2J2NmFF?=
 =?utf-8?B?RGZHZVNNT1ZpNFVxbTNidzBnM25ObW1FMHR0UTg4aUVkT3Rqd3YzbkxWWStF?=
 =?utf-8?B?SVlsNnFyZCs2R2g4MUdUNk91ZmhJd09kUUJkYmM2ZHE5eENScTQ3STRsUXhT?=
 =?utf-8?B?b3YzMlpOdmlhb21PODlaR1JnWkNZOFJ6T2U4djNSNTViblhVYVdqYlVIdHdz?=
 =?utf-8?B?ZnpnWDFMQ1JtTlo2THdsMXFKbkV4Y05xeW9NWnNISXZ2L1VlR3RKeUxwdjA2?=
 =?utf-8?B?U3FvUlRxcHBtSXZCRW1XaFkraXhnMWgrdGNHNUZIZmxwcnBiYTgwRm0vVVZY?=
 =?utf-8?B?dXlwSTFhcTMvMkZNVjVITzZlTlZLQ3ZHRUhaODgyeVRaUElvOGEva29QMFhQ?=
 =?utf-8?B?Q2RHMnJkUUtULzlDeDQvTzdEVytQMlVRajhOam45dXlpR2VYRjhDa1gyR0Fh?=
 =?utf-8?B?c2ozQ05vT0NEOEJlTmo3dGo4M3oyMXZYZ2dFNGJHcWFXZ2N6Ylc0bDVPc0Yw?=
 =?utf-8?B?dGcvUUMwUGxRWmhuRkc4ZWUyckpiM2hKeG8yTTAvQS9GRURRM3o5QkcwNk5j?=
 =?utf-8?B?bzNpaVFrUHpsVFU3eGxuNFpYZTdxNWhyUGZ3dXdkNDVRdHdzdXFpczRrUm5w?=
 =?utf-8?B?cmsxbkZnVllVM0R5eml5dC9XZkxZNUFtbTNRZ29kUk1hVzhLbFRLalNFd01M?=
 =?utf-8?B?N3A4bkNtWU1pTUZXQjNPaVFMUnhWbEY0WmxSekNjNitGS3RkWlBQUjM4M0pX?=
 =?utf-8?B?Z213WWY2eFUyUHNJS2laWWVjMnExL2llakxjME95dnovTVZsT1RDcCtXUjM5?=
 =?utf-8?B?ZVRMejJDYkNrdWRuL1Y0WUJOTVo1MXVnNFd2M2VxUFRweFNsdkE4VkxITm5D?=
 =?utf-8?B?Si9sQVd6aEFDZS9LWktOc3NtUHo5WDA2VXVGV1JxN0xQSmtteU5BcnNJblpE?=
 =?utf-8?B?UXNDS3BwVGI3dXlRZmtjTmszcEI0czdWNkhOYTl4ZUtjZWw2UGVqRWlzQ3po?=
 =?utf-8?B?SEJGT2pQT0t0bHNkVFNqcGhmYndsdG9YSy9FS01iRkpOcVBjSjdjd1o5RTUz?=
 =?utf-8?B?UVFoYyt4b3V2MnBTTG5tazRvMm1KK2RvT0VjRXl4U2hZRk1DbkRPbWQ3U09h?=
 =?utf-8?B?M3VkcHRIMkNtYk80SnIzZGpBMnVhck4ybXNnQXpzSGlmNE1kcGV4RDBUVkpa?=
 =?utf-8?B?RFFaMDRhc1ZXWnRITDU5cng4UmZIeFNmU1B2ZUxWS2VtSFVJcm92OE5OMGVF?=
 =?utf-8?B?WUV0dTljdmhtTzhNNUF6MlBqejY4Z3Urd1NOUVcyM2x0L2tuUGh1djMvb1ZE?=
 =?utf-8?B?TDdtdVlYSElFSG1CNDhzckNGY2YxU3BOQlJTN21LeGFmaDd2OGlnVjR2ZXlZ?=
 =?utf-8?B?ZnhBdThBeWpwMjd2ckFKWFROU3p2U013Zk9ma0pUeGNUNnd3b1ViMDNBVEgx?=
 =?utf-8?B?NVNYbnY1WThBTmpMTXZRekdkejZvWURDQW82QnozRE80R2dZZE1KS1JTdGVv?=
 =?utf-8?B?TGVlbWo3U3lRNWpxYlFNakxyTmtnZG1Ma094MjVhT3dFNUx4N1hpK2x0Q3Zk?=
 =?utf-8?B?aDJxZnlROWl0cHF6VS95enppbGpBOWJ0N3B5bkRLZFdqRVdDNk8vSTI4bGxn?=
 =?utf-8?B?MWZ3Tld5ODJCVFNGL1ZWR0xnWVhmbHV5ZE50TU9pQ1dvTlhzNU9qaFBiVFJy?=
 =?utf-8?B?alNwd1Zkb2Z2dHFHUHZLTHNmaWhIR0ZsUVFYbzdEMVhjNFpSVmtTcTlFSW5o?=
 =?utf-8?B?Z25GVXBWSFptRndZdWU4Nk95OXpobml3YXgrVSs2c3pxendhYWFJKzZ4R2RJ?=
 =?utf-8?B?V2Z2T1Y5bFkxMVZTNGI4QlFpK3VSMDN5bHJDRFBWTFVhejZJaEh3WGxOQVQx?=
 =?utf-8?B?Z01PWHJLWmhoODF1UVBWdWVXcmw0SWEycEU4OTJzWHNHSmhDNzhqTDVrTm8y?=
 =?utf-8?B?dVJKUy84N08xcUNMbkJzQlFrUStzVlhSZDZaSVBOY1BFV0hVV213Y0ZyTytp?=
 =?utf-8?B?RFg0VkFWM3hCWEhGTENjYVdXVzM5dU5SNlFkWXBhUHlCN3JWbm9qOHVkWDJN?=
 =?utf-8?Q?tzh9fqpUq3ZrJU/YozAy2D09d?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e143049-49cd-48b6-de16-08dbf100555a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 17:26:33.8608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HcO1/neCC+Hm9/nZJCtdl7p0aFUaDPFppcXR89YZA2LkBPKFRG7XIbdhGBsD8u9TufQP0G7ObkunmB6GZFHi1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5066

On 11/29/2023 03:13, Ma Jun wrote:
> From: Evan Quan <quanliangl@hotmail.com>
> 
> The newly added WBRF feature needs this interface for channel
> width calculation.
> 
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
> Signed-off-by: Evan Quan <quanliangl@hotmail.com>

I think the order should be the other way around for these SoB as 
"you're signing off on Evan's work".

Otherwise LGTM.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> --
> v8->v9:
>    - correct typo(Mhz -> MHz) (Johnson)
> v13:
>   - Fix the format issue (IIpo Jarvinen)
> ---
>   include/net/cfg80211.h | 9 +++++++++
>   net/wireless/chan.c    | 3 ++-
>   2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index b137a33a1b68..08f0d7184167 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -976,6 +976,15 @@ const struct cfg80211_chan_def *
>   cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1,
>   			    const struct cfg80211_chan_def *chandef2);
>   
> +/**
> + * nl80211_chan_width_to_mhz - get the channel width in MHz
> + * @chan_width: the channel width from &enum nl80211_chan_width
> + *
> + * Return: channel width in MHz if the chan_width from &enum nl80211_chan_width
> + * is valid. -1 otherwise.
> + */
> +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width);
> +
>   /**
>    * cfg80211_chandef_valid - check if a channel definition is valid
>    * @chandef: the channel definition to check
> diff --git a/net/wireless/chan.c b/net/wireless/chan.c
> index 2d21e423abdb..dfb4893421d7 100644
> --- a/net/wireless/chan.c
> +++ b/net/wireless/chan.c
> @@ -141,7 +141,7 @@ static bool cfg80211_edmg_chandef_valid(const struct cfg80211_chan_def *chandef)
>   	return true;
>   }
>   
> -static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
> +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
>   {
>   	int mhz;
>   
> @@ -190,6 +190,7 @@ static int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width)
>   	}
>   	return mhz;
>   }
> +EXPORT_SYMBOL(nl80211_chan_width_to_mhz);
>   
>   static int cfg80211_chandef_get_width(const struct cfg80211_chan_def *c)
>   {