Received-SPF: pass (google.com: domain of linux-wireless+bounces-236-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b5d672096829cb9645205c3803e9471cef98643f.camel@sipsolutions.net>
Subject: Re: iwlwifi: WRT: Invalid buffer destination
From: Benjamin Berg <benjamin@sipsolutions.net>
To: Len Brown <lenb@kernel.org>, Johannes Berg <johannes.berg@intel.com>, 
 Miri Korenblit <miriam.rachel.korenblit@intel.com>, Gregory Greenman
 <gregory.greenman@intel.com>
Cc: Linux PM list <linux-pm@vger.kernel.org>, "open list:NETWORKING
	DRIVERS (WIRELESS)" <linux-wireless@vger.kernel.org>
Date: Thu, 30 Nov 2023 12:07:32 +0100
In-Reply-To: <CAJvTdKkcxJss=DM2sxgv_MR5BeZ4_OC-3ad6tA40TYH2yqHCWw@mail.gmail.com>
References: 
	<CAJvTdKkcxJss=DM2sxgv_MR5BeZ4_OC-3ad6tA40TYH2yqHCWw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2023-11-29 at 21:03 -0500, Len Brown wrote:
> Automated suspend/resume testing is grumpy about iwlwifi, because
> iwlwifi dmesg's with the words "Invalid" and "Failed", which our
> heuristics highlight as issues a human should review.
>=20
> If this is normal, can you delete the messages?=C2=A0 If this is a
> failure, can we fix it?

I had been looking a bit at either removing messages with level
KERN_ERR or or fixing the underlying issue. With the plan to get clean
runs with regard to kernel log level at least. I didn't look for
specific keywords like "invalid" or "failed" though.

I believe The debugfs one is an actual bug (harmless though) for which
a patch should be posted soon.

I don't remember seeing the "WRT: Invalid buffer destination" message.
Will need to take a closer look, but quite likely it should just be
hidden unless the IWL_DL_FW debug flag is set (i.e. use IWL_DEBUG_FW).

Benjamin

>=20
> thanks,
> -Len
>=20
> [20168.810433] iwlwifi 0000:00:14.3: WRT: Invalid buffer destination
> [20168.967756] iwlwifi 0000:00:14.3: WFPM_UMAC_PD_NOTIFICATION: 0x20
> [20168.967806] iwlwifi 0000:00:14.3: WFPM_LMAC2_PD_NOTIFICATION: 0x1f
> [20168.967857] iwlwifi 0000:00:14.3: WFPM_AUTH_KEY_0: 0x90
> [20168.967919] iwlwifi 0000:00:14.3: CNVI_SCU_SEQ_DATA_DW9: 0x0
> [20168.969387] iwlwifi 0000:00:14.3: RFIm is deactivated, reason =3D 4
> [20169.074918] iwlwifi 0000:00:14.3: Failed to create debugfs
> directory under netdev:wlp0s20f3
> [20169.076354] iwlwifi 0000:00:14.3: Failed to create debugfs
> directory under netdev:p2p-dev-wlp0s20


>=20
> ps.
>=20
> lenb@lenb-Dell-XPS-13-9315:~/src/linux$ grep IWLWIFI .config
> CONFIG_IWLWIFI=3Dm
> CONFIG_IWLWIFI_LEDS=3Dy
> CONFIG_IWLWIFI_OPMODE_MODULAR=3Dy
> # CONFIG_IWLWIFI_DEBUG is not set
> CONFIG_IWLWIFI_DEBUGFS=3Dy
> CONFIG_IWLWIFI_DEVICE_TRACING=3Dy
>=20
>=20