Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp526620rdb; Thu, 30 Nov 2023 10:52:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYelP8XxEHinGLZp6ok0ztV+4WsqGuHm+DuXFAc3Q6GTRucaj9PVooLZgSy3ZrkYhhbGRV X-Received: by 2002:a17:903:2448:b0:1cf:c67f:8212 with SMTP id l8-20020a170903244800b001cfc67f8212mr17838125pls.50.1701370360988; Thu, 30 Nov 2023 10:52:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701370360; cv=none; d=google.com; s=arc-20160816; b=ykogOwWyLucdpR5JaecrRmqREozEFuJ3jb2B/evecCpT1kH1vlLp4Kn6nD3rebNfiq 92P8FkFyru5PZed9lSHVGMof+WBoXL0b8/0j7G9s2QAcRePsUi8mOd4ZrGdeaFL8E+aC 8oC2wiI/e8mf/NEXg+C6shtf3mzQKqtIel1uExAkplk+aHMXN9E4wN4ZhunIsYicStFL JgWYlI+Ym/cT8/RyD6aaKlOoozuyJGgiWWeSt+Wl54PdqYx6U8z5JtWwb88UoY1LyenO N3kwZS1ACafKWMZUsG8ZmrgagFbrVCDIXJRMBtyl3blIwBNlKTUsJinBAWScK2T3wVrN bRLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=AWW3+CM6ik8ct0WgTHPe92vPRix8fk2yUkpq6s6NPmE=; fh=HiTx0qpwrmopGrcngbG/j5iAz9IkkKfgwIA58C18IEQ=; b=x4MggQz32Sx3rlnRRdyswmNqFCLyKTOB5Sx7Rr9ii9YcX7EuRmxXp/efTudFqiI2Eq OQNzRX3kO4M01AyK2Nvzo9qEBsMTAgQUyceatLk/beqxYv4yrXr4eMwiMhYzUWeRlqC4 kGwEQHiDPgD7HWIT3pM3it/xubHND4aROB3tmTSFSz3a00wXwsAfSA8i3h83vDh+rRMu iVwdqzHiY7BUskVeNNTf0wbLHi/t6/3HWp3yfUoiMLQMu8aS7UftthwIwyZ1NcompLg7 AOPmmpNelXW5hMKTzRvPBBPSNdNCTx3AlivvQNvJzhBVcIRYT0Y5uCTo7zQGhFocxGRm c0bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=ri5MnTIy; spf=pass (google.com: domain of linux-wireless+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id jj2-20020a170903048200b001cc529610e3si1588641plb.342.2023.11.30.10.52.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 10:52:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=ri5MnTIy; spf=pass (google.com: domain of linux-wireless+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 023BAB20EF5 for ; Thu, 30 Nov 2023 18:52:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E09C454FB4; Thu, 30 Nov 2023 18:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="ri5MnTIy" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25988194 for ; Thu, 30 Nov 2023 10:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=AWW3+CM6ik8ct0WgTHPe92vPRix8fk2yUkpq6s6NPmE=; t=1701370354; x=1702579954; b=ri5MnTIycccPpBKLZfJAaaGwRy0sXvRPPQtz5qmcjciMUue c6MXBscMaF5imv0vgQmf0Vh9WD8tOWHKc0prDicYRCv/ZKc5Imf17PzrtmUjgh/rjWlaAhPok8L1r MVqZQloU7yUdY93lfFwON4ntx58zBDsfDxyULzurNNVvnLYmZTsxaNJkxasbrVT9G77T6VqK4PIJj Astp+kfcUzcixDuDNIm6lphHm1XIRNEoFWjao/Nj4jzekn+cmmTMN3fN9/ahqdpWzCFrZVds6pGt+ rIbAaKhsAaaHatng6+m4rAkxz+cbomQMZKePwKEVVQJ9u2hHUoIrhJgB3FkJKrVA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1r8m9D-0000000A9Km-3gAp; Thu, 30 Nov 2023 19:52:28 +0100 Message-ID: <678c2ed84d94b2f87bdeaf165bd769996a395e7c.camel@sipsolutions.net> Subject: Re: [RFC PATCH] wifi: cfg80211: fix CQM for non-range use From: Johannes Berg To: Kees Cook Cc: Jeff Johnson , Michael Walle , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-wireless@vger.kernel.org, Max Schulze Date: Thu, 30 Nov 2023 19:52:26 +0100 In-Reply-To: <202311301045.6DA830F7@keescook> References: <202311090752.hWcJWAHL-lkp@intel.com> <202311090752.hWcJWAHL-lkp@intel.com> <1c37d99f722f891a50c540853e54d4e36bdf0157.camel@sipsolutions.net> <202311301016.84D0010@keescook> <01e3663e9e1418a183ee86251e0352256494ee28.camel@sipsolutions.net> <202311301045.6DA830F7@keescook> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2023-11-30 at 10:46 -0800, Kees Cook wrote: > >=20 > > > Does this warning go away if "len" is made unsigned? > >=20 > > Thing is, neither Kalle nor I can even reproduce the warning locally, s= o > > it's a bit hard to check ... not even with their config and gcc 12.2.0 > > (nix, rather than debian though.) >=20 > Ah! Hmm. Let me see if I can coax out the warning locally... >=20 Actually, I see it now with wireless-next + that patch ... I had put it into wireless, not wireless-next :) johannes