Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp545874rdb; Thu, 30 Nov 2023 11:22:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiiJMKc/KXdgiDKfo+wveGjD4Uip+pMs3cAGK7fQSTuk1CIjGrIaXkDvKjCNR5Ptdu5cOI X-Received: by 2002:a05:6214:629:b0:67a:22aa:a9e6 with SMTP id a9-20020a056214062900b0067a22aaa9e6mr23892257qvx.55.1701372142220; Thu, 30 Nov 2023 11:22:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701372142; cv=none; d=google.com; s=arc-20160816; b=VhVncKEZIC37VtQj52uc2OAkQfFVjLY9G06rVBt7JQKDA9aQWzfIlbiGdVwmpwTUww MT2N4rMeBKfbY6zdgFayCf0ryEepA/IIFBKdsZtmWKc31TU6+ocw7N4+cNM3FyJl39OA kEmVcTiOcZCAvy+03OYp0ySZ29GxuFhXJZ2Y86bZcEm/yHz5rfrP+cHj3qpfogDrkqyh U2GsIU833HUxjOpDbbAhtdqUY2X0ftCzpTP759S0MyU8IBKTfxXciOhCsi1GULmIJ6Ed GSj9e639BTJdQ2NW6JLoLAIxLCubWDipMFmihVYnB/RFc4MKKSglnH6eFZL9RiEzr0/N ZEzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=fb2rCV6WAZEw+nzahFhyVSGc2KaA+xi5EwjxVDbzNc0=; fh=s43lmNgUdJ14124+UO1Nfqm/LGLQzyO4bnEKV8gkBTQ=; b=r/7+IKVc/iA1T+tVPrdEENty+HcNXQUNoMOrTBWW2b9urVW3qSQnUJEImET3N8P0dw t4k3bso7CvJs9T+UaB5nMlSoMLbmX9ZyYSHG6VJLaq8EGdxiM3Mf+UjJPS5W0oF1vX3h 8VeAIp6Rhd66X+0gFm9knxa4XdPUnO/TZgJokLzedaOJuiYEq+RuwaKqSaneSFvuhai1 NVXBUFUYWIYYRF9KYaBkbgJ33i/IHsgikZOUZbRDsUYyS4+O5R1j+cBAxPiCeNMPAvX4 rkhNJKkYgmTPvZEYOHxycfaGBw6xiONObldlhyjy/NxzWkn2O0Qm2OxFo0mQhOxfR2rQ WLYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VsquDq4o; spf=pass (google.com: domain of linux-wireless+bounces-257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id cx10-20020a056214188a00b0067a15416e51si1560677qvb.204.2023.11.30.11.22.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 11:22:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VsquDq4o; spf=pass (google.com: domain of linux-wireless+bounces-257-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-257-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C347E1C20CBA for ; Thu, 30 Nov 2023 19:22:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E7F7822066; Thu, 30 Nov 2023 19:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VsquDq4o" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDA4A5FEED; Thu, 30 Nov 2023 19:22:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0612BC433C7; Thu, 30 Nov 2023 19:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701372139; bh=+7y/SoB0oekqe7y/gT33Bcz6gA3T+9Zo09+5P9Q1naY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=VsquDq4ozGnJM2AsKT3V7db8lUQAoqT0ku4HmN0YvirIuLernk2g6FugwhGB31BNO RGhvSPM4wZEgJqhm44lXuMQaEY9YDmdKy5B94p2cBC5Sqqz36CQNRxfFJ37s0mcC6k eYk/07nfaZ0MahKCvz9cbGNJv66QctAShqOvhfeY1O+fCh1AlzVdRkEHiKxM2BueXN 9CZiO7p1eKUseIb2B+NUaN0sHU7c5HOFjtPB/qp4pjfMrgAiS0v/5WNjlM0jfRVkm8 fyubqsRUC1nO8b5v+BYyb2fD56UDZuheA0JjkIbkG7oh/hoFHGktuycO44Q37I/jSc HiTnyJSpBzIxQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [wireless-next,v3,1/2] wifi: rtlwifi: rtl8821ae: phy: remove some useless code From: Kalle Valo In-Reply-To: <20231127013511.26694-1-suhui@nfschina.com> References: <20231127013511.26694-1-suhui@nfschina.com> To: Su Hui Cc: pkshih@realtek.com, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, Su Hui , lizetao1@huawei.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170137213526.1963309.2251579800524493199.kvalo@kernel.org> Date: Thu, 30 Nov 2023 19:22:16 +0000 (UTC) Su Hui wrote: > Clang static checker warns: > > Value stored to 'v1' is never read [deadcode.DeadStores] > Value stored to 'channel' is never read [deadcode.DeadStores] > > Remove them to save some place. > > Signed-off-by: Su Hui > Acked-by: Ping-Ke Shih 2 patches applied to wireless-next.git, thanks. cda37445718d wifi: rtlwifi: rtl8821ae: phy: remove some useless code bc8263083af6 wifi: rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior -- https://patchwork.kernel.org/project/linux-wireless/patch/20231127013511.26694-1-suhui@nfschina.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches