Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp936496rdb; Fri, 1 Dec 2023 02:40:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyykQfglUyAhITPG7ceQdYkqMyQ5jmeRlX/11fNpOyus5hWYfgcJrYJlflONWIM8qThRyU X-Received: by 2002:a05:6358:78c:b0:16b:c401:955b with SMTP id n12-20020a056358078c00b0016bc401955bmr28462054rwj.2.1701427232097; Fri, 01 Dec 2023 02:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701427232; cv=none; d=google.com; s=arc-20160816; b=tn+xYrn7gspEGjs0Hl3sI6e3T06koLSygHnKhQ47ddIqByTCpGq9PnjidUHgzcSxFQ MkPUNLI/bTUH3C1u4XrQGVGKQN0XNgsANMWKyNz9B6XhgCkC4AbZx5Lpp0xMabaTLwEu nmA5yCubiqHhRVE/eXrRkkCWVl8dIXdPnQXotdQfCJJIsaI91M9xKek/cgk+OFhTD6qb 8aMgHkpMdhtoC2DWh8PJyaOIIER98JwRVsHvbawfxavAgR0sir/+Wbwn2tRj8k0NR8Xe rqLdHMFa8vJp3vx2dnjKwfxzYswRwalvFWCGNjIlN+MFYZa2QJuT2SZYOb/1DOb8McMd sRTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=SiegYa/Sc8Niqe2N5lQFvjZ37kHcXjntqwehQUb99WE=; fh=2GZY/U2AYZSRm52+t8rjg0AVUvtkiHh4KhGZiS9fuqU=; b=qsNbI3iAZTU3T4d7XfMH9LOL08hx49g1NvrOGA+Q7rL8FOo9PNxcyaBSKeCHfU5U1z 35lXSGfW0UNfYfkWPp1jjb8/rDM4OJHXNkeFgP8E+YscOxbnXPs48MV+Vn3K6uoUJ6sg 4ISJ5LAd9Ghn7Qfi1w3lvkvl+VNAyOUTCX7pRHe8KEX5yBCG0aU4cOqvSSS6R2NdGMoZ cjXy+Utx8OrY123FfodMUVcEos275UL2n+DWU6t6I4UiwFf2wdOOcI8r6T9jV011M01c bOdksO+NT6jhZhww9kPJTz4rY6qWeZWaJGZRqv5882vgP0DWQNUOnPnkg9otR3jnvHQ2 +9Yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-280-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-280-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b14-20020a056a000a8e00b006cdc6987539si3162927pfl.266.2023.12.01.02.40.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 02:40:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-280-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-280-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-280-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 185D9B2102D for ; Fri, 1 Dec 2023 10:40:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 88CA620300; Fri, 1 Dec 2023 10:40:26 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24B6196; Fri, 1 Dec 2023 02:40:22 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 1B27220645; Fri, 1 Dec 2023 11:40:21 +0100 (CET) Date: Fri, 1 Dec 2023 11:40:19 +0100 From: Francesco Dolcini To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com Subject: Re: [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments. Message-ID: References: <20231128083115.613235-1-yu-hao.lin@nxp.com> <20231128083115.613235-12-yu-hao.lin@nxp.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231128083115.613235-12-yu-hao.lin@nxp.com> On Tue, Nov 28, 2023 at 04:31:14PM +0800, David Lin wrote: > 1. Moved struct mwifiex_ieee80211_mgmt from cfg80211.c to fw.h. > 2. Defined WLAN_AUTH_NONE instead of using 0xFFFF directly. > 3. Changed host_mlme of struct mwifiex_adapter to host_mlme_enabled. > 4. Moved mwifiex_check_key_api_ver() to end of mwifiex_ret_get_hw_spec(). > 5. Redefined MWIFIEX_MGMT_HEADER_LEN and MWIFIEX_AUTH_BODY_LEN. You should fix the existing patch, not create a fixup commit on top. Francesco