Received-SPF: pass (google.com: domain of linux-wireless+bounces-291-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kalle Valo <kvalo@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Justin Stitt <justinstitt@google.com>,  Gregory Greenman
 <gregory.greenman@intel.com>,  linux-wireless@vger.kernel.org,
  linux-kernel@vger.kernel.org,  linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] wifi: iwlwifi: fw: replace deprecated strncpy with
 strscpy_pad
References: <20231019-strncpy-drivers-net-wireless-intel-iwlwifi-fw-dbg-c-v2-1-179b211a374b@google.com>
	<202311301354.0DAC97C@keescook>
Date: Fri, 01 Dec 2023 14:27:15 +0200
In-Reply-To: <202311301354.0DAC97C@keescook> (Kees Cook's message of "Thu, 30
	Nov 2023 13:55:04 -0800")
Message-ID: <874jh2rtuk.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Kees Cook <keescook@chromium.org> writes:

> On Thu, Oct 19, 2023 at 05:44:59PM +0000, Justin Stitt wrote:
>> strncpy() is deprecated for use on NUL-terminated destination strings
>> [1] and as such we should prefer more robust and less ambiguous string
>> interfaces.
>> 
>> Based on the deliberate `sizeof(dest) ... - 1` pattern we can see that
>> both dump_info->dev_human_readable and dump_info->bus_human_readable are
>> intended to be NUL-terminated.
>> 
>> Moreover, since this seems to cross the file boundary let's NUL-pad to
>> ensure no behavior change.
>> 
>> strscpy_pad() covers both the NUL-termination and NUL-padding, let's use
>> it.
>> 
>> Link:
>> https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
>> [1]
>> Link: https://github.com/KSPP/linux/issues/90
>> Cc: linux-hardening@vger.kernel.org
>> Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> Thread ping. Can the wireless folks please pick this up?

Yeah, I'll take this directly to wireless-next.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches