Received-SPF: pass (google.com: domain of linux-wireless+bounces-308-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: David Lin <yu-hao.lin@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>, "kvalo@kernel.org"
	<kvalo@kernel.org>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>
Subject: RE: [EXT] Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue
 for WPA3.
Thread-Topic: [EXT] Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey
 issue for WPA3.
Thread-Index: AQHaIdVU9t1lQPz4s0eWS+tlGSPAM7CUOvWAgADPRyA=
Date: Fri, 1 Dec 2023 22:41:47 +0000
Message-ID:
 <PA4PR04MB9638C4474BE296DF113F22C2D181A@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20231128083115.613235-1-yu-hao.lin@nxp.com>
 <20231128083115.613235-3-yu-hao.lin@nxp.com>
 <ZWmyQ9ilyAPGJmft@francesco-nb.int.toradex.com>
In-Reply-To: <ZWmyQ9ilyAPGJmft@francesco-nb.int.toradex.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?DLcT2nENcTh0M8hhp3BOTpZeuRH9Ltx/P8wvPB8oPPy3wprahxukT8gMIsi/?=
 =?us-ascii?Q?R5I2pRXyfld4Ej6+SBFO3AU54t5sRj/xfFQgta4HAVW5eK+rdoL+UYnyuPAz?=
 =?us-ascii?Q?b0oCG6QYColF1kDHrhx0C/HHO6UA1UYOd96omtKlCh8aE3GhIeG4Yuq7sagm?=
 =?us-ascii?Q?rw0tuVslnrBpwUs/FcdZTv1MBPdsqdDEuOqEvgcbn1cFidSmBe1IVSdAfwEB?=
 =?us-ascii?Q?V6TfOIi40QeERZAldLKEuUpDCjNYJ+BmUFCh9KsbM3R8569ElW95MjRNODDL?=
 =?us-ascii?Q?Gqw/0Z1azSPIlOxdGWCJNVYuMMNuoPmy2YPPGpRLPwZus42t4EoVudttMUzR?=
 =?us-ascii?Q?wBQlTkJbdp6cbRYb8mTvgVv5LHZ4JAEH3GMDLufpYt9nLtJHUx4DMkoZxe7m?=
 =?us-ascii?Q?o3RX/MR9PxOv5PrQCbkmPzi4s4kpUbycvEOEo5I4qBpqxN1IIOm1s5L56dR+?=
 =?us-ascii?Q?vZkuOfCeDn6363vpOp9FGK0ODM85TJwcKOlB5Tu9wIA4G0P/vMLX+XdLLmcb?=
 =?us-ascii?Q?OtF9dEEbe56nL5buxH210P7JC2KzIU8tPFh/3VXu/qZl14uSHTQX3hhNyPH1?=
 =?us-ascii?Q?99iELXjLOBwonN/NmyoOe2+a/JkaXWSvwvdQ4GE56v2D3TS0K1CDaSW5BNu2?=
 =?us-ascii?Q?eukrhffVJStK+TrgSaA6Am/2rha6WokEVGvPeim3vDpoj8DQt5PosFUnPTd1?=
 =?us-ascii?Q?qNkSecfKKweD/1yZ+p1ManoVb8GgWTL+omaDoz+J38QlvgrSOYvlRfKvLd9j?=
 =?us-ascii?Q?IUmIHm5YnmIY+5Rmg7eDFpRnLCquK42/hmrfWJ+a8IPhRzywue49iONMTdyq?=
 =?us-ascii?Q?ULsKPG5DrHThnzhr0IZro17HM01h0AM3O0ZJa0RFu+CayM4bGWZ/08yB8yrL?=
 =?us-ascii?Q?xaUAzQXcZOXt+1kTbg52wpVY6g48ar9RT7IMnbjYn2fC0UfHi4MxTKu4LDe6?=
 =?us-ascii?Q?38OV/2DK6TbLl9PIUIXYRAxrDKjhCnuPnMgJvBARPipowYvQGbwVHgH2bxL2?=
 =?us-ascii?Q?KczceN0VhhN/NX8s0PFAhfdnRqSHyy/r4g2cQAnrNjOn7wsjkMjzxe4lb38h?=
 =?us-ascii?Q?DiJtnS6BoimQu7sk1fT7J5aqPSI/cF4U3VQHmoQcsGU0EMPzQ/yzg4EtHw3x?=
 =?us-ascii?Q?F1QuP9JhCueBCgMLnPX9mWEPdFDo/rQnefdzgL+OxmSWsj7rWuynQ9kWFzP+?=
 =?us-ascii?Q?lqhxvsFYZ3PPHLkYUNrLfz+sZABohUIf63CbwSG55SZeOwUXuQ1LSwpHFuxp?=
 =?us-ascii?Q?/WKnoI30WgbOWS+7sOi4ht6hVUM5F3bb23PDDO64QpPItGTpviMVa8bfyoaB?=
 =?us-ascii?Q?cGPLPg8iLY4J0nfXEuVYbB59qOoO51lLvijDJBV6irGC0qejKKhb1orhV2qt?=
 =?us-ascii?Q?JAfZtCs5meq9e24X2YvwTEu2TTSxQINsFthdaAKGPV0kW/qVG0mT4j9UsITU?=
 =?us-ascii?Q?1zwXTC+s8X5e891pwCzI1fl23+8rUBrowQUW4ww5lLYoZgsdKPnLpEIBImNh?=
 =?us-ascii?Q?LQ2Lyk6GETGUJoz6MRVxlXFbT8Cuy1/IOJ6J3WaeHEim0zjaNd013YvGleQU?=
 =?us-ascii?Q?Q/xJf0n117DapzMRui8l1CYudDm8iKfq0EgeNK8F?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: abb1aacf-593c-44bf-77e3-08dbf2beb3ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2023 22:41:47.4797
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oeiYWW0T/6ol2jFrkTse5dQZ9k4WgebPr8UhUn5Vex+Hzh83u5HdjUc+khU0lW8l9lvqpCrJsn2HXVRN2sZhcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7875

> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Friday, December 1, 2023 6:16 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Pete
> Hsieh <tsung-hsien.hsieh@nxp.com>
> Subject: [EXT] Re: [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issu=
e for
> WPA3.
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Tue, Nov 28, 2023 at 04:31:05PM +0800, David Lin wrote:
> > If host mlme is enabled, gropu rekey offload should be disabled.
> >
> > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > ---
> >  drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 +++
> >  drivers/net/wireless/marvell/mwifiex/main.c     | 4 ++++
> >  drivers/net/wireless/marvell/mwifiex/util.c     | 7 +++++++
> >  3 files changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > index 40c39e4765f7..3d59e6a441b9 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > @@ -3657,6 +3657,9 @@ static int mwifiex_set_rekey_data(struct wiphy
> *wiphy, struct net_device *dev,
> >       if (!ISSUPP_FIRMWARE_SUPPLICANT(priv->adapter->fw_cap_info))
> >               return -EOPNOTSUPP;
> >
> > +     if (priv->adapter->host_mlme)
> > +             return 0;
>=20
> this is a fixup of the previous patch, you should not introduce an issue =
and
> fix it in the following patch. Please make it correct in the first place =
fixing up
> that patch.
>

This is the main fix for this issue. If host mlme is enabled, there is no n=
eed for firmware to do group rekey off load.
=20
>=20
> > +
> >       return mwifiex_send_cmd(priv,
> HostCmd_CMD_GTK_REKEY_OFFLOAD_CFG,
> >                               HostCmd_ACT_GEN_SET, 0, data,
> true);  }
> > diff --git a/drivers/net/wireless/marvell/mwifiex/main.c
> > b/drivers/net/wireless/marvell/mwifiex/main.c
> > index d99127dc466e..3bebb6c37604 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/main.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/main.c
> > @@ -802,6 +802,10 @@ mwifiex_bypass_tx_queue(struct mwifiex_private
> *priv,
> >                           "bypass txqueue; eth type %#x, mgmt
> %d\n",
> >                            ntohs(eth_hdr->h_proto),
> >                            mwifiex_is_skb_mgmt_frame(skb));
> > +             if (ntohs(eth_hdr->h_proto) =3D=3D ETH_P_PAE)
> > +                     mwifiex_dbg(priv->adapter, MSG,
> > +                                 "key: send EAPOL to %pM\n",
> > +                                 eth_hdr->h_dest);
>=20
> this is just debug code, at a first glance not sure i

It will be helpful for driver to print out authentication, association and =
EAPoL key handshaking.
This kind of information will only be printed out when station is associate=
d to AP. It won't affect
TP of driver.

> > diff --git a/drivers/net/wireless/marvell/mwifiex/util.c
> > b/drivers/net/wireless/marvell/mwifiex/util.c
> > index 23675c1cecae..ff1b2f162c30 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/util.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/util.c
> > @@ -482,8 +482,15 @@ mwifiex_process_mgmt_packet(struct
> mwifiex_private *priv,
> >                               return 0;
> >
> >                       if
> > (ieee80211_is_deauth(ieee_hdr->frame_control)) {
> > +                             mwifiex_dbg(priv->adapter, MSG,
> > +                                         "auth: receive deauth
> from %pM\n",
> > +                                         ieee_hdr->addr3);
> ditto
>=20
> >                               priv->auth_flag =3D 0;
> >                               priv->auth_alg =3D 0xFFFF;
> > +                     } else {
> > +                             mwifiex_dbg(priv->adapter, MSG,
> > +                                         "assoc: receive disasso
> from %pM\n",
> > +                                         ieee_hdr->addr3);
> ditto