Received-SPF: pass (google.com: domain of linux-wireless+bounces-322-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <1700948088-16140-mlmmj-666d2532@vger.kernel.org>
 <CAOE0c97T1cVvqFkqfrP_h53X08yQ7kLinZP09L35nVHc_V89+g@mail.gmail.com>
 <5abfc98859504795b50f7f343784c886@realtek.com> <CAOE0c96uJ9x8gbJZdHiMEiOM5gTd_ZqM_rUV7Cs1NyA_t0Ncfg@mail.gmail.com>
 <CAOE0c97fDaLTfsMJVmEh4HxOAPY19kD60qsV5AKJbWW5nnqWzw@mail.gmail.com> <b4cfd676c0b24d98b82302aefac7f379@realtek.com>
In-Reply-To: <b4cfd676c0b24d98b82302aefac7f379@realtek.com>
From: Ali Ghandour <gandour.ali@gmail.com>
Date: Sat, 2 Dec 2023 11:23:54 +0200
Message-ID: <CAOE0c97NvXFhttfNNm3+NsXw9SKV7sC-nJriwF43pujvJugvSg@mail.gmail.com>
Subject: Re: Lenovo LOQ rtw_8852be
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>> Can I know the type of your platoform Lenovo LOQ? Is it a regular notebo=
ok computer?

LOQ 15IRH8 - Type 82XV
I am using a dual boot with Windows and Ubuntu 22.04

>> The PCI EXT capabilities locate from 100h. Not sure if host controller d=
river limits to display them?
I did not get your question. Can you say it again please?


Ali

On Tue, Nov 28, 2023 at 3:21=E2=80=AFAM Ping-Ke Shih <pkshih@realtek.com> w=
rote:
>
>
>
> > -----Original Message-----
> > From: Ali Ghandour <gandour.ali@gmail.com>
> > Sent: Monday, November 27, 2023 2:19 PM
> > To: Ping-Ke Shih <pkshih@realtek.com>
> > Cc: linux-wireless@vger.kernel.org
> > Subject: Re: Lenovo LOQ rtw_8852be
> >
> > seems like the same error persists after downgrading:
> >
> > $ uname -r
> > 5.17.0-1035-oem
> >
> > $ sudo dmesg | grep rtw
> > [    4.859848] rtw89_8852be 0000:09:00.0: loaded firmware
> > rtw89/rtw8852b_fw-1.bin
> > [    4.860214] rtw89_8852be 0000:09:00.0: enabling device (0000 -> 0003=
)
> > [    4.861546] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5
> > (da87cccd), cmd version 0, type 5
> > [    4.861550] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5
> > (da87cccd), cmd version 0, type 3
> > [    4.861556] rtw89_8852be 0000:09:00.0: MAC has already powered on
> > [    4.867246] rtw89_8852be 0000:09:00.0: [ERR]pci config read 719
>
> We did changes after 5.18, but your 5.17 print out error with
> "pci config read" instead of "dbi_r8_pcie".
>
> -       ret =3D rtw89_dbi_read8(rtwdev, RTW89_PCIE_L1_CTRL, &bdr_ori);
> +       ret =3D rtw89_pci_read_config_byte(rtwdev, RTW89_PCIE_L1_CTRL, &b=
dr_ori);
>         if (ret) {
> -               rtw89_err(rtwdev, "[ERR]dbi_r8_pcie %X\n", RTW89_PCIE_L1_=
CTRL);  // 5.17
> +               rtw89_err(rtwdev, "[ERR]pci config read %X\n", RTW89_PCIE=
_L1_CTRL); // 5.18
>                 return ret;
>         }
>
> Uh. I know the reason why you see the new one, because 8852be is supporte=
d
> by kernel 6.2, and distro backport the driver to old kernel.
>
>
> If you can build driver yourself, please revert below patch and try again=
.
> Fixes: db38d9cd26c9 ("rtw89: use pci_read/write_config instead of dbi rea=
d/write")
>
> > >
> > > $ lspci -tv
> > > -[0000:00]-+-00.0  Intel Corporation Device a715
>
> I will try to Google to see if I can find some information about this PCI=
 host controller.
>
> Can I know the type of your platoform Lenovo LOQ? Is it a regular noteboo=
k computer?
>
> > >
> > > $ sudo lspci -s 09:00.0 -xxxx
> > > 09:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device b8=
52
>
> [...]
>
> > > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>
> In my side, lspci with '-xxxx', it can display PCI configuration space 0 =
~ ff0.
> In your side, lspci has the same behavior as driver that can't read 0x719=
.
>
> The PCI EXT capabilities locate from 100h. Not sure if host controller dr=
iver
> limits to display them?
>
> Ping-Ke
>