Received-SPF: pass (google.com: domain of linux-wireless+bounces-403-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <71d0f8424661b0d7b2c371e422416854790e477a.camel@sipsolutions.net>
Subject: Re: [PATCH AUTOSEL 4.14] wifi: cfg80211: lock wiphy mutex for
 rfkill poll
From: Johannes Berg <johannes@sipsolutions.net>
To: Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org, 
	stable@vger.kernel.org
Cc: syzbot+7e59a5bfc7a897247e18@syzkaller.appspotmail.com, 
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com,  linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Date: Mon, 04 Dec 2023 21:50:29 +0100
In-Reply-To: <20231204203735.2095033-1-sashal@kernel.org>
References: <20231204203735.2095033-1-sashal@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-12-04 at 15:37 -0500, Sasha Levin wrote:
>=20
> +++ b/net/wireless/core.c
> @@ -202,7 +202,9 @@ static void cfg80211_rfkill_poll(struct rfkill *rfkil=
l, void *data)
>  {
>  	struct cfg80211_registered_device *rdev =3D data;
> =20
> +	wiphy_lock(&rdev->wiphy);

This can't even _build_ on this old kernel?!

Anyway, my locking rework only went into 6.7, so this doesn't make sense
in any stable kernel, it's just not required.

johannes