Received-SPF: pass (google.com: domain of linux-wireless+bounces-405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <95265243715c2f7cbb5ef94083d64e1a17d8ee04.camel@sipsolutions.net>
Subject: Re: Thinkpad P17 keep hanging in ipv6_addrconf addrconf_verify_work
 / netlink in 6.4 and 6.6
From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Marc MERLIN <marc@merlins.org>, netdev@vger.kernel.org, 
	linux-wireless@vger.kernel.org, ilw@linux.intel.com, 
	intel-wired-lan@lists.osuosl.org, Tony Nguyen <anthony.l.nguyen@intel.com>
Date: Mon, 04 Dec 2023 22:17:50 +0100
In-Reply-To: <20231204131615.26b57722@kernel.org>
References: <20231202171326.GB24486@merlins.org>
	 <20231204004003.GB29484@merlins.org> <20231204073515.GA9208@merlins.org>
	 <69717129398d05b18df1c1300bfb41da268c52a0.camel@sipsolutions.net>
	 <20231204131615.26b57722@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2023-12-04 at 13:16 -0800, Jakub Kicinski wrote:
> > > > [  363.945511]  __mutex_lock.constprop.0+0x18b/0x291
> > > >=20
> > > > [  363.945531]  igc_resume+0x18b/0x1ca [igc 1a96e277f8878a2a3c95992=
26acd0eeb7de577b7] =20
> >=20
> > this is trying to acquire the RTNL, by looking at the code
> >=20
> > > > [  363.945566]  __rpm_callback+0x7a/0xe7
> > > > [  363.945578]  rpm_callback+0x35/0x64
> > > > [  363.945587]  ? __pfx_pci_pm_runtime_resume+0x40/0x40
> > > > [  363.945592]  rpm_resume+0x342/0x44a
> > > > [  363.945600]  ? __kmem_cache_alloc_node+0x123/0x154
> > > > [  363.945614]  __pm_runtime_resume+0x5a/0x7a
> > > > [  363.945624]  dev_ethtool+0x15a/0x24e7 =20
> >=20
> > but this already holds it
> >=20
> > So looks like bug in the 'igc' driver wrt. runtime PM locking.
> >=20

So actually maybe it shouldn't be a bug there, I posted this:

https://patchwork.kernel.org/project/netdevbpf/patch/20231204200710.40c291e=
60cea.I2deb5804ef1739a2af307283d320ef7d82456494@changeid/

but I don't know this driver at all, and ethtool not that well ...

johannes