Received-SPF: pass (google.com: domain of linux-wireless+bounces-408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Arnd Bergmann <arnd@kernel.org>, Kalle Valo <kvalo@kernel.org>,
        "Gustavo
 A. R. Silva" <gustavoars@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>, DeanKu <ku920601@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rtw89: avoid stringop-overflow warning
Thread-Topic: [PATCH] rtw89: avoid stringop-overflow warning
Thread-Index: AQHaJoPDzskCZ6cSukWy41fWNynHdbCZ0mZg
Date: Tue, 5 Dec 2023 00:26:14 +0000
Message-ID: <6161bfc56d51413283915031e8d4d653@realtek.com>
References: <20231204073020.1105416-1-arnd@kernel.org>
In-Reply-To: <20231204073020.1105416-1-arnd@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, December 4, 2023 3:30 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Kalle Valo <kvalo@kernel.org>; Gus=
tavo A. R. Silva
> <gustavoars@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; DeanKu <ku920601@realtek.com>; linux-w=
ireless@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] rtw89: avoid stringop-overflow warning

Subject prefix should be "wifi: rtw89: ..."

>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> After -Wstringop-overflow got enabled, the rtw89 driver produced
> two odd warnings with gcc-13:
>=20
> drivers/net/wireless/realtek/rtw89/coex.c: In function 'rtw89_btc_ntfy_sc=
an_start':
> drivers/net/wireless/realtek/rtw89/coex.c:5362:50: error: writing 1 byte =
into a region of size 0
> [-Werror=3Dstringop-overflow=3D]
>  5362 |                 wl->dbcc_info.scan_band[phy_idx] =3D band;
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> In file included from drivers/net/wireless/realtek/rtw89/coex.h:8,
>                  from drivers/net/wireless/realtek/rtw89/coex.c:5:
> drivers/net/wireless/realtek/rtw89/core.h:1441:12: note: at offset [64, 2=
55] into destination object
> 'scan_band' of size 2
>  1441 |         u8 scan_band[RTW89_PHY_MAX]; /* scan band in  each phy */
>       |            ^~~~~~~~~
> drivers/net/wireless/realtek/rtw89/coex.c: In function 'rtw89_btc_ntfy_sw=
itch_band':
> drivers/net/wireless/realtek/rtw89/coex.c:5406:50: error: writing 1 byte =
into a region of size 0
> [-Werror=3Dstringop-overflow=3D]
>  5406 |                 wl->dbcc_info.scan_band[phy_idx] =3D band;
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> drivers/net/wireless/realtek/rtw89/core.h:1441:12: note: at offset [64, 2=
55] into destination object
> 'scan_band' of size 2
>  1441 |         u8 scan_band[RTW89_PHY_MAX]; /* scan band in  each phy */
>       |            ^~~~~~~~~
>=20
> I don't know what happened here, but adding an explicit range check
> shuts up the output.

The callers of these two cases will pass RTW89_PHY_0 (0) as argument of phy=
_idx,
and will extend to pass RTW89_PHY_1 (1) in the future, but should not be la=
rger
than 1.

I don't mind to add this checking, but I really don't know what happened ne=
ither.
A statement 'wl->scan_info.band[phy_idx] =3D band;' did similar thing in th=
e same
function, but why doesn't gcc complain this?