Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp232302rdb; Tue, 5 Dec 2023 04:07:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtpexpLhcWzEYDlK6f8240oT254isrNXanVcR+WPAHycdQX2W6z+sOvOLlk3lZpsQ5n+xK X-Received: by 2002:a17:906:73c2:b0:a17:780f:c5e5 with SMTP id n2-20020a17090673c200b00a17780fc5e5mr2298379ejl.52.1701778054184; Tue, 05 Dec 2023 04:07:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701778054; cv=none; d=google.com; s=arc-20160816; b=ZBaslMgjeIXhWHtcO87NicK6oYjGQVzk+rT4su4dbK5re8jrSxjTtOCjFtycrf+Ubf nMugZ70jVRAs26zk9PJyfMVJKjW4JWT+10+0yTbByLE3aIWIFgfSva1ZBxIcDxRCh0B4 8HZywWwbwQKM+i6RDZl6RYbq46IblSCZEvZztyjxHcgwi/mUDMKym3TGzgBWsnGW48JY Xk0NwgZBjF9ZB3HV9s4oOZqR46qsXdVpbnW8piqhdRgAAgCZlPNx9FQok1nx13Nv30/r ybskDPFuNbq07sYN88YVkPqxcuGsKkDaabT3MFrv7MSlxPwJ2qeYrPmBcKZBMQRL3pxG DVDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=UW0HYee6eU6ROhRxw/5sjimyIXMfkgsZkotTNmpddAQ=; fh=2umn379M+nFvn0hOFSntmnHAG1RMLSWJj7ue7V9cMzw=; b=NbKR95IeHlSJ0r/J3e8msKBCzVtJr2CCAf3Ck48CPEVMFdwHAb9xtAAiZ6UptejUS+ GQmo+r/ajqNcg47t1wtoQHH6zaipu7AlImgDxYEPqpve5tCLjIEHfzWR/5q/ivz5xSLC 32+6cITbtS+e/XOQNRU3D1jpr4dN8JlRSXAXnuuj6Ni0wdv+OMPW6Rq66dghifUxDSN+ tOkWhy/8gdnF1uQ5eh2JBJQAeWEKDXcDmfYO9kTGGT1GovKMYzWDRMxNSV/JRXsOsQdu 5x3EM/To9k1J+gC0zrPPRaZGoBCwEMrlAkwzi+r8iyaLpHWmaEmk3mPbgZz4HzMupWfo OtBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FeIL0PFp; spf=pass (google.com: domain of linux-wireless+bounces-419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-419-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id xo18-20020a170907bb9200b00a1c703b54d5si472033ejc.292.2023.12.05.04.07.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:07:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FeIL0PFp; spf=pass (google.com: domain of linux-wireless+bounces-419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-419-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ECC4C1F212AB for ; Tue, 5 Dec 2023 12:07:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D91259E4D; Tue, 5 Dec 2023 12:07:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FeIL0PFp" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 102C756770 for ; Tue, 5 Dec 2023 12:07:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EBA3C433C7; Tue, 5 Dec 2023 12:07:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701778049; bh=lnKGDBAxB8eBxYMZ/Jm5VaF2xsTMrWs6Ne8f9Aw7vjQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=FeIL0PFp9XGF5OiflZcnKBgpJ//p36iYTkX/bRoAle2kHEzcDvrUZCHdpOhhr5D3+ ldQAE4WtTVYfd2PGV9YOfKswfZdtnGpHsYGbfYEpvQkfw1/7IwUHsyp8sRAaXQrA8Q UojGTHrerdAC6owGBFQpmABMzdXyZGpsmi7pK7D+pLMsJgEsniRpmd81ake4f5uQla dkx9nvEIUp3QCzUtueyQoPwEGW+owYCBivuQkRGbdUyI6CZ4egK7S1zogzSe1pdqVg QYIgrreNVZhXj2Yjhc7l9YUU2NEs6EnPjviUhmL8wih+v4NtgFP+qA541saOL87hXd w7IkezvhTO8mg== From: Kalle Valo To: "Jiri Slaby (SUSE)" Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Fietkau , Nick Kossifidis , Luis Chamberlain Subject: Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna References: <20231205111515.21470-1-jirislaby@kernel.org> Date: Tue, 05 Dec 2023 14:07:25 +0200 In-Reply-To: <20231205111515.21470-1-jirislaby@kernel.org> (Jiri Slaby's message of "Tue, 5 Dec 2023 12:15:15 +0100") Message-ID: <874jgwrgxu.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Jiri Slaby (SUSE)" writes: > clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is > unused. The commit 1048643ea94d ("ath5k: Clean up eeprom > parsing and add missing calibration data") added it, but did not use it > in any way. Neither, there is a later user. > > So remove that unused member. > > [1] https://github.com/jirislaby/clang-struct clang-struct looks really nice, especially if it can also find unused structures. What about unused defines or enums, any chance to find those in the future? :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches