Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp269155rdb; Tue, 5 Dec 2023 05:10:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1nibM2mp246KwX0Sg8a9/e9S4WRT+JqQWR3QdMojuADHYJS5A+CAE+7Q7rwUXfqGedonC X-Received: by 2002:a05:6359:6794:b0:170:17eb:9c4f with SMTP id sq20-20020a056359679400b0017017eb9c4fmr5030858rwb.48.1701781821105; Tue, 05 Dec 2023 05:10:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701781821; cv=none; d=google.com; s=arc-20160816; b=YCo5B1LyB5mEEMS5SN6dwtnpb62flvhxFMEPs0HHTnX+WF7wwe4w+vTzpXJ46LlJ8J 8rmOOla0llqOM4cNkyxQP1eICM0EoXvN35eu4v59nlIaXhwWgc5fFbanzkPPG7QrVuUd TvgIrikifZIGRfyjoM/EMKgMhk78iMBmCpT3t9+oy2gcEXz20T2xVOmXnF9SCZwhVD5y j+pERHAVupxQdakLcWSmgWGj0f9n+BNWcPHPOLmPWuDLNBvkn0BhNtJpthDtUPWwLC7J bfX3nqxDdLsqXXJA49BxpP/Ku9FQKbKQdTncn/gGBbfRYShWNLOU7GlwvCpoEK5LdQrA UMvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=aoMOngnmcG1wcfaImof1Sk2kMIQCM6E0o7Z7Gu86VXk=; fh=ggJWrlLWUV356MzVOiWlk33Gl2JAduo62hJQtaI4vVY=; b=kEBvQrsAVPc13ewG0grcB31MkC5ABZpoD+4d198Mj0jzaieckhAxxk2bwuOMDCyuTm czVypS6gZNPMiNQwvNdEQO7u8gyFAzJ25h/cyRjyQYSRjH9kvlXgBWxtJzmdB3zSqXKQ +fGqNBJIhdgtLcvJkQ1iEMRmD7MrBCFD11eFCr1tu4mAnpqpVntw4rcU6i5PTLjAjddO o3R4JTp6tbzZewBteCGc3BZPye3L43cpcQLvnggw8ZgcexSFd7weCYS3G3BUkIPja6BW w3dqY/yQWZykVU3JHxtVhFBV6OTcj8oDt+q7BCynYdlK/B83v/nIrM5tiSo3cTBgy4mu OmdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id cb10-20020a056a02070a00b005c69365abadsi3282770pgb.499.2023.12.05.05.10.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 05:10:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless+bounces-422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-422-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 62CA02815E8 for ; Tue, 5 Dec 2023 13:10:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C23D5C901; Tue, 5 Dec 2023 13:10:17 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB143196; Tue, 5 Dec 2023 05:10:13 -0800 (PST) Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3331752d2b9so4241187f8f.3; Tue, 05 Dec 2023 05:10:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701781812; x=1702386612; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aoMOngnmcG1wcfaImof1Sk2kMIQCM6E0o7Z7Gu86VXk=; b=Ail3r3/4IPTyHYnKWUB89NIS9Mx/CIYqZWUBzWNGIqIx2L6u/SDE2nwyfM3XeRj0PT jtR69mzI13OD3Bvyk+YGrT4ehPwyaCltyaMz4iOYHpmfUcO1x9+Um0jwz7yFJYLmOyu3 j5aWXEkCoWWYRl4IpwzGSj8C1cXMnFhsbqE92iWnJEVCR0zVQTXcW0svCcv45cpeS+uK QeV29MJNYJkRNx8KyI2wOaimTBXg71qaGoDGOQgV9zLsaz3J2e6nER99VHJRxkPtfZck 2eON0eAFI6McvwH1jtk61/83KUOlm9/7oxqE8RpZSvEZqT8WI13Xif/rAa/l4JWOThm/ 4EJg== X-Gm-Message-State: AOJu0YxV5ksdARUfDSqCP0Z4jb6fui59ZwY0PC8cxH1m7pDvx4EyibqD Eop5WrraLXI/qJDMaGhBgfg= X-Received: by 2002:a05:6000:1f9b:b0:333:3c4d:7ff4 with SMTP id bw27-20020a0560001f9b00b003333c4d7ff4mr3390444wrb.69.1701781811976; Tue, 05 Dec 2023 05:10:11 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id t16-20020a5d5350000000b0033338c3ba42sm9545676wrv.111.2023.12.05.05.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Dec 2023 05:10:11 -0800 (PST) Message-ID: Date: Tue, 5 Dec 2023 14:10:11 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ath5k: remove unused ath5k_eeprom_info::ee_antenna Content-Language: en-US To: Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Fietkau , Nick Kossifidis , Luis Chamberlain References: <20231205111515.21470-1-jirislaby@kernel.org> <874jgwrgxu.fsf@kernel.org> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <874jgwrgxu.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05. 12. 23, 13:07, Kalle Valo wrote: > "Jiri Slaby (SUSE)" writes: > >> clang-struct [1] found that ee_antenna in struct ath5k_eeprom_info is >> unused. The commit 1048643ea94d ("ath5k: Clean up eeprom >> parsing and add missing calibration data") added it, but did not use it >> in any way. Neither, there is a later user. >> >> So remove that unused member. >> >> [1] https://github.com/jirislaby/clang-struct > > clang-struct looks really nice, especially if it can also find unused > structures. It can... > What about unused defines or enums, any chance to find those > in the future? :) All of that is IMO possible (I'm not completely sure about macros, despite clang ASTs provide a lot of info. Incl. info about them and their expansion). It's all limited only by man-force: me. thanks, -- js suse labs