Received-SPF: pass (google.com: domain of linux-wireless+bounces-428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: James Prestwood <prestwoj@gmail.com>,  <linux-wireless@vger.kernel.org>,
  <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2] wifi: ath10k: add support to allow broadcast action
 frame RX
References: <20231116173246.40458-1-prestwoj@gmail.com>
	<be472f3f-c1fc-4ab4-acca-1b1357c8b407@quicinc.com>
Date: Tue, 05 Dec 2023 17:27:50 +0200
In-Reply-To: <be472f3f-c1fc-4ab4-acca-1b1357c8b407@quicinc.com> (Jeff
	Johnson's message of "Thu, 16 Nov 2023 12:05:31 -0800")
Message-ID: <87il5cpt3d.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 11/16/2023 9:32 AM, James Prestwood wrote:
>
>> Broadcast action frames are needed for the Device Provisioning
>> Protocol (DPP) for Presence and PKEX Exchange requests. Currently
>> just ath9k has this capability so this is being enabled for
>> ath10k (for at least one hardware variant).
>> 
>> Add a new capability flag in ath10k_hw_params to indicate support
>> for receiving multicast action frames. This bit is then checked
>> when configuring the RX filter and (if set) multicast action frame
>> registration is enabled.
>> 
>> Until more hardware can be tested only the "qca6174 hw3.2" variant
>> is enabling this feature.
>> 
>> Note: I went ahead and removed the 'changed_flags' mask operation
>> since it had no effect, that parameter was not being used anywhere.
>> 
>> Tested-on: QCA6174 hw3.2 WLAN.RM.4.4.1-00288-
>> 
>> Signed-off-by: James Prestwood <prestwoj@gmail.com>

[...]

>> --- a/drivers/net/wireless/ath/ath10k/core.c
>> +++ b/drivers/net/wireless/ath/ath10k/core.c
>> @@ -381,6 +381,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>>  		.hw_restart_disconnect = false,
>>  		.use_fw_tx_credits = true,
>>  		.delay_unmap_buffer = false,
>> +		.mcast_frame_registration = true,

I forgot to mention that I prefer explicitly setting the false cases as
well so I added those in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=51daeadfbecc13b2ce8a9a4b7697e4056cbb358f

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches