Received-SPF: pass (google.com: domain of linux-wireless+bounces-498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <cd25fd96fa391d3c8a5811d995d166cbb0b0efe5.camel@sipsolutions.net>
Subject: Re: [PATCH] net: rfkill: gpio: set GPIO direction
From: Johannes Berg <johannes@sipsolutions.net>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>, Josua Mayer
 <josua@solid-run.com>, linux-wireless@vger.kernel.org,
 netdev@vger.kernel.org,  linux-kernel@vger.kernel.org
Cc: kernel@pengutronix.de, stable@vger.kernel.org, "David S. Miller"
	 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Date: Wed, 06 Dec 2023 14:16:15 +0100
In-Reply-To: <20231206131336.3099727-1-r.czerwinski@pengutronix.de>
References: <20231206131336.3099727-1-r.czerwinski@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2023-12-06 at 14:13 +0100, Rouven Czerwinski wrote:
>=20
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -126,6 +126,16 @@ static int rfkill_gpio_probe(struct platform_device =
*pdev)
>  		return -EINVAL;
>  	}
> =20
> +	if (rfkill->reset_gpio)
> +		ret =3D gpiod_direction_output(rfkill->reset_gpio, true);
> +	if (ret)
> +		return ret;
> +
> +	if (rfkill->shutdown_gpio)
> +		ret =3D gpiod_direction_output(rfkill->shutdown_gpio, true);
> +	if (ret)
> +		return ret;
>=20

That's weird, you need ret to be inside the if. It's even entirely
uninitialized if you don't have ACPI, if you don't have reset/shutdown.

johannes