Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1301519rdb; Wed, 6 Dec 2023 14:52:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjkxYpgbfSHqsF6UjUPQNwVGN3j1WhQk4eLhjFicWyMCygOJrakUUpX79vSAUM62Fd3Ou/ X-Received: by 2002:a17:906:7c4c:b0:a19:a19a:eab7 with SMTP id g12-20020a1709067c4c00b00a19a19aeab7mr1016609ejp.112.1701903175604; Wed, 06 Dec 2023 14:52:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701903175; cv=none; d=google.com; s=arc-20160816; b=G4NelF3ro7arKpmO5twcFjzjxLyEtiN94lcvM90KCQnQPZcGruWP2lVWKBxADDaOon hKy+HMmTvlBSQ/+xtmXM9bAzOqVfD1Mnuhz9KhvSKMbvfz4hwdiU/CLGFiChJSB8FI4T SAIf2RiMwbZDQl1QcGjVnXpKjqJPUT/dShQ3H7v4f9O5hje8uwm5vzCbQavjRZvbUlm9 RZ77NDrLwuwCBXrV1bh5GQfNYGPnvSKFMiXdEYf7SuwEBAyoxieMxk0V+a+iJrDyaDWB 2aiT7n7F363LrJ3NSpYqUrBRzrI/K52hgZp4fkqqW+PNu6VM7/cNeXx4QtTusEkZ4OMg 8mhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:from; bh=DczOegt1+I90oTxtgqgKOl5ZDtesbrsjx0yi+MFHP4w=; fh=DfRKzmyGCSJ+Frs6jvUXv6BFgzfocISNpjK69wx7hNA=; b=i4C6iX0GWC4hQ5c+/ei+LLqbzJptPemRK8SeUmFgjkTyCQvHVu0Is6gjDZSaJkyTSz 41XXMC9Ln9iXpXnAt2bmUlDwtssIIjmIJJhts4EPclW04hXTltzvlcVe+ATY7fRoCmCO 9c+WEiNgYr8lbu02wrSI5pIUA5083q4D7Q1/eN1x9YQfLOJ2JISkzLuuehqhg7ENYVxt Jl9/Q+BBoedUEowb96T7TZFnUXc33OOw/YvAsyWOqRfs8jxQBGXTG696SSMhA/uIefMz rw5WjC0L0B2vIxz6E+BFgvpENG2xZYgrOmqI/SUrUY6QNNEW3caYMisdimEAD+fJSuJW y8Hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=upHrR79U; spf=pass (google.com: domain of linux-wireless+bounces-516-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-516-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id u14-20020a1709064ace00b00a1d55eb3c6dsi8195ejt.859.2023.12.06.14.52.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 14:52:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-516-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b=upHrR79U; spf=pass (google.com: domain of linux-wireless+bounces-516-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-516-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5E10D1F21909 for ; Wed, 6 Dec 2023 22:52:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5209A70997; Wed, 6 Dec 2023 22:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="upHrR79U" X-Original-To: linux-wireless@vger.kernel.org Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D452D18D for ; Wed, 6 Dec 2023 14:52:42 -0800 (PST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1701903160; bh=DczOegt1+I90oTxtgqgKOl5ZDtesbrsjx0yi+MFHP4w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=upHrR79UXAAIfnW8H2OGD+SXGNkVNOcLdv2Pn708Pf1X2hi9SeX0m0/du/9Avatdj m7OHomMIcA1rnDR6S+0fmceOxvPPwhxBXmoURWm7g1oLTnVdnJG1EpMkcvnQ38hNWp DtnumeHZ26pRzvAViR4pQQQdpQsYAxUvW3pEvGdDfbxsTs8Ro1IhjDsMw82/iqDE1C H5y4QTV7qCBBmu+Rye5IXCLHK6W8a71sODE/Di0qpyE8cZ+uoAUhbe1ZeF2NvvI6dk /0mvxGWQpnFGi4HB/WLqe2Aa9Hpb9AGyHFU9ZwyyqhZlgSUp8G6WXlVDh3bPpJuvxx mGCroeL2WvgQQ== To: Dmitry Antipov , Johannes Berg Cc: linux-wireless@vger.kernel.org, Dmitry Antipov Subject: Re: [PATCH] wifi: mac80211: cleanup airtime arithmetic with ieee80211_sta_keep_active() In-Reply-To: <20231206060935.612241-1-dmantipov@yandex.ru> References: <20231206060935.612241-1-dmantipov@yandex.ru> Date: Wed, 06 Dec 2023 23:52:39 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87v89bkkp4.fsf@toke.dk> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dmitry Antipov writes: > Prefer native jiffies-wide 'unsigned long' for the 'last_active' field of > 'struct airtime_info' and introduce 'ieee80211_sta_keep_active()' for air= time > check in 'ieee80211_txq_keep_active()' and 'ieee80211_sta_register_airtim= e()'. > > Signed-off-by: Dmitry Antipov Sure, this seems like a reasonable cleanup! Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen