Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1657762rdb; Thu, 7 Dec 2023 05:37:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCoCsTO/VYxoYKtJAoxeCtRHb2E5OA1Ky0XADP/3GD0bRPZ8zjDGDQWwoIf+/eUjszM/uh X-Received: by 2002:a05:6e02:20ea:b0:35d:7946:bec6 with SMTP id q10-20020a056e0220ea00b0035d7946bec6mr3458731ilv.112.1701956255870; Thu, 07 Dec 2023 05:37:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701956255; cv=none; d=google.com; s=arc-20160816; b=FdcgTix9DuSE45/2PGH4OEylEvBRbBYMEEHcdphibKF5tGEzKoMh4BElzQ0UHx0pR6 mEtBxm9z9yZqRVxccKdKqmJQX2muXbNsi3vefhNJ52SLvT8Ly3DUDSyaBtAuvKVaTtDn 5/PuBbGVE2RIgNoE/yAqZS3H18wgeqargp62Ob7MF9pu6rX6o9me2U8FPNcHDfmRD0BH JDAv3/ubkMZOsYCprtMShRVk7ApYKCAPgPD3NzQTrpDTNKcPCUg4l1b+dlsEm9Aecmwf nCORwUfEWzawQjo98OuX1U7EULurDTLn9yazza74IECTl01I72ff0iZPTCA04CqY714d AlsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=KS6jSWhcFfyrz4cE1wVhTQZB5ky0aKWcMH4UGeF4goE=; fh=sdUTEt/aNFOYOur7ti1Q2MvSsHBufmOAta2FUvmdsMo=; b=x/e9F2hw7mT80vTDCvjWv+6RzrUR6uh12BBmXTCQFV/YFVk610IkqcMp6MdeQSsYGP nyB+rTmUaZogdGz3RMxEH8qBn6kFY3rAG0YEyQd1TLLMSUYrsdOKezw/j93PryVLtZAr B5YAw3QeWqjv9RMoQhIqeGkG3wqVhcjzNjRrYB2HtJsJ0cgoi5vuOQ/QxUp23ZvHHPTn BRNjL9V3Tydv8gAPv2qvU7oJs27P5Tv20gE/+3SFM4S4qgjx/PPegAPnO3JsPq4c+azV VTN64mT7Ru9ZDtIUtCAvxAUHjDjFsM7efFQeMgXo1qcoXetKHNfm8mCE1mZ7r5RJ1JS0 Dl7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=houRMNEI; spf=pass (google.com: domain of linux-wireless+bounces-543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-543-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l26-20020a65681a000000b005c1b322b3c1si1207787pgt.681.2023.12.07.05.37.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 05:37:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless+bounces-543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=houRMNEI; spf=pass (google.com: domain of linux-wireless+bounces-543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-543-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 889A32823F8 for ; Thu, 7 Dec 2023 13:37:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25AF640BEA; Thu, 7 Dec 2023 13:37:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="houRMNEI" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B33E405DD for ; Thu, 7 Dec 2023 13:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61A8EC433C8; Thu, 7 Dec 2023 13:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701956252; bh=oCmGs8e7SpjRy+Vd5XKtyFu88CTeYgJP7xGauoAW/Zs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=houRMNEIKs5cps4+ut1rJB6U6ivq4OYj4xgU5uMkj3D172jurecKVSCsnop3dPe9k U1d5J0WTypOBy0mJsBPHkgTzDou4XdkrxEPFJhxqSVBqcsCnzFpTWBC3ckxc/ohIFf bc+BKuc/PmLSE+E3dGpcOm/UKakpZFc2PNUv7QqxDf47q3lcS0wbBMs7CZjNpS39b1 cAVr1z01JphowU1OpdW44MaAaSKWhl/ZdrYATRDEoh5iELzpVv7Pv4ZJ8VB76asH8K BCPwNmqd85v3Klogh8iIZuSOWomr7ZUYonIRCGwlOMVi70dRBCqkPBExMgPVwaRLny tmBnBC7iSl5tA== From: Kalle Valo To: miriam.rachel.korenblit@intel.com Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Johannes Berg , Brian Norris Subject: Re: [PATCH 13/13] iwlwifi: pcie: add another missing bh-disable for rxq->lock References: <20231207025018.1022929-1-miriam.rachel.korenblit@intel.com> <20231207044813.acb50fabb4cc.I8f19713c4383707f8be7fc20ff5cc1ecf12429bb@changeid> Date: Thu, 07 Dec 2023 15:37:29 +0200 In-Reply-To: <20231207044813.acb50fabb4cc.I8f19713c4383707f8be7fc20ff5cc1ecf12429bb@changeid> (Miri@web.codeaurora.org's message of "Thu, 7 Dec 2023 04:50:18 +0200") Message-ID: <87h6ku5e1y.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain miriam.rachel.korenblit@intel.com writes: > From: Johannes Berg > > Evidently I had only looked at all the ones in rx.c, and missed this. > Add bh-disable to this use of the rxq->lock as well. > > Fixes: 25edc8f259c7 ("iwlwifi: pcie: properly implement NAPI") > Reported-by: Brian Norris > Signed-off-by: Johannes Berg > Signed-off-by: Miri Korenblit "wifi:" prefix missing. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches